Closed Bug 1362954 Opened 4 years ago Closed 4 years ago

--disable-accessibility fails to build

Categories

(Core :: DOM: HTML Parser, defect)

55 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: mats, Assigned: ryanvm)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR
1. Add "ac_add_options --disable-accessibility" to your .mozconfig
2. build

ACTUAL RESULTS

 3:11.40 In file included from /md1/objdir/md1/src/mc/parser/html/Unified_cpp_parser_html0.cpp:20:
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:842:38: error: no member named 'aria_valuemax' in 'nsGkAtoms'
 3:11.40     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuemax), ALL_NO_PREFIX);
 3:11.40                           ~~~~~~~~~~~^
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:844:38: error: no member named 'aria_labelledby' in 'nsGkAtoms'
 3:11.40     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_labelledby), ALL_NO_PREFIX);
 3:11.40                           ~~~~~~~~~~~^
 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:846:38: error: no member named 'aria_describedby' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_describedby), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:848:38: error: no member named 'aria_disabled' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_disabled), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:850:38: error: no member named 'aria_checked' in 'nsGkAtoms'
 3:11.41     ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_checked), ALL_NO_PREFIX);
 3:11.41                           ~~~~~~~~~~~^
...
A regression from bug 1269490 perhaps?
Blocks: 1269490
Flags: needinfo?(hsivonen)
Keywords: regression
Yes. Fewer atoms should be behind #ifdef ACCESSIBILITY in the atom list.
Flags: needinfo?(hsivonen)
Fixes the build locally for me. Green on Try too.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f23fee7b9d52c11404b0801498507855243a510
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8865578 - Flags: review?(hsivonen)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c66e8805fcb
Move some atoms outside of the ACCESSIBILITY guard to fix --disable-accessibility bustage. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/7c66e8805fcb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.