Closed
Bug 1362954
Opened 7 years ago
Closed 7 years ago
--disable-accessibility fails to build
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: RyanVM)
References
Details
(Keywords: regression)
Attachments
(1 file)
5.54 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
STR 1. Add "ac_add_options --disable-accessibility" to your .mozconfig 2. build ACTUAL RESULTS 3:11.40 In file included from /md1/objdir/md1/src/mc/parser/html/Unified_cpp_parser_html0.cpp:20: 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:842:38: error: no member named 'aria_valuemax' in 'nsGkAtoms' 3:11.40 ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuemax), ALL_NO_PREFIX); 3:11.40 ~~~~~~~~~~~^ 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:844:38: error: no member named 'aria_labelledby' in 'nsGkAtoms' 3:11.40 ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_labelledby), ALL_NO_PREFIX); 3:11.40 ~~~~~~~~~~~^ 3:11.40 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:846:38: error: no member named 'aria_describedby' in 'nsGkAtoms' 3:11.41 ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_describedby), ALL_NO_PREFIX); 3:11.41 ~~~~~~~~~~~^ 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:848:38: error: no member named 'aria_disabled' in 'nsGkAtoms' 3:11.41 ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_disabled), ALL_NO_PREFIX); 3:11.41 ~~~~~~~~~~~^ 3:11.41 /md1/src/mc/parser/html/nsHtml5AttributeName.cpp:850:38: error: no member named 'aria_checked' in 'nsGkAtoms' 3:11.41 ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_checked), ALL_NO_PREFIX); 3:11.41 ~~~~~~~~~~~^ ...
Reporter | ||
Comment 1•7 years ago
|
||
A regression from bug 1269490 perhaps?
Comment 2•7 years ago
|
||
Yes. Fewer atoms should be behind #ifdef ACCESSIBILITY in the atom list.
Flags: needinfo?(hsivonen)
Assignee | ||
Comment 4•7 years ago
|
||
Fixes the build locally for me. Green on Try too. https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f23fee7b9d52c11404b0801498507855243a510
Updated•7 years ago
|
Attachment #8865578 -
Flags: review?(hsivonen) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c66e8805fcb Move some atoms outside of the ACCESSIBILITY guard to fix --disable-accessibility bustage. r=hsivonen
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c66e8805fcb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Updated•7 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•