1363140 - [e10s] SVG image set using content:url(...) bounces around when changing its opacity on hover

Status: RESOLVED WORKSFORME

(Core :: SVG, defect, P2)

Description

[Dão Gottwald [:dao]]

See bug 1351827 comment 21.

Here's the patch that triggers the issue in about:home: https://reviewboard.mozilla.org/r/137150/diff/1

Comment 1

[Dão Gottwald [:dao]]

Can't reproduce on Beta (54).

Comment 2

[Alice0775 White]

Attachment: mozilla.svg

Comment 3

[Alice0775 White]

Attachment: index.html

I can reproduce on Firefox50 with e10s

Comment 4

[Alice0775 White]

Regression window w/ e10s:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=64148714c156&tochange=1088d4ec5fad

Regressed by: Bug 1085783

Comment 5

[Astley Chen (inactive)]

If I read the bug correctly, the logo will be bounced around on hover and become smaller when zoom-in.
However, I'm not seeing the problem on FF55/FF56 builds when loading the test case attached by Alice.
Do I miss anything?

Comment 6

[Alice0775 White]

At least, I can reproduce the bounds Nightly56.0a1 32 and 64bit with e10s on Windows10 64bit.
And it is not matter HWA on or off.

Comment 7

[Astley Chen (inactive)]

(In reply to Alice0775 White from comment #6)
> At least, I can reproduce the bounds Nightly56.0a1 32 and 64bit with e10s on
> Windows10 64bit.
> And it is not matter HWA on or off.

Interestingly, the issue can only be reproduced on linux/Windows platforms only.
Thanks for prompt feedback.

Comment 8

[Astley Chen (inactive)]

Do you have any ideas about the cause?

Comment 9

[u459114]

Since this is a regerssion of bug 1085783, it should be relative to the change in ComputeSnappedImageDrawingParameters[1]
I will look into in when I have time.

[1] https://hg.mozilla.org/mozilla-central/rev/b339f54f20f6

Comment 10

[u459114]

ok, let me handle it.

I tried to disable opicty async animation by always return false in nsDisplayOpacity::CanUseAsyncAnimation, and can not repro this issue after the change.

bool
nsDisplayOpacity::CanUseAsyncAnimations(nsDisplayListBuilder* aBuilder)
{
  return false;
}

Comment 11

[u459114]

1. We can repro this bug only by turning on E10S
2. This bug appears right after kicking off an async opacity animation
   2.1 Before animation, we paint "mozilla" logo on the root painted layer.
   2.2 Hover on "mozilla" logo and animation begin, "mozilla" logo image is promoted onto a dedicate painted layer. And you will see a bigger image right after we paint "mozilla" logo onto this new layer.
   2.3 Animation end. "mozilla" logo shrinked becasue we paint "mozilla" logo back on the root painted layer again.

Peter, can you find someone look into this issue? It seem to be a gfx bug.

Comment 12

[Peter Chang[:pchang]]

I tried to dump the image content when animation happened and found the content(SVG) already contained the two thin white bars in the left/right side of a SVG image.

The content is the same with/without e10s, but it looks like I couldn't reproduce this issue with the non-e10s mode.
The layer size is the same with/without e10s for this SVG animation.

I will fire another bug why composition result for this SVG animation are different between e10s and non-e10s.

CJ, I think you can use this bug to check the sanp problem.

[1]https://pastebin.mozilla.org/9027496

Comment 13

[Panos Astithas (he/him) [:past] (please ni?)]

Does this still happen in 57?

Comment 14

[Robert Longson [:longsonr]]

This should be fixed now, can anyone confirm that it is?

Comment 15

[violet.bugreport]

Comment 3 can no longer reproduce, mark as WFM.