Closed Bug 1363422 Opened 4 years ago Closed 4 years ago

Remove devtools.webide.widget.enabled pref from SeaMonkey after Bug 1183962.

Categories

(SeaMonkey :: General, enhancement)

All
Unspecified
enhancement
Not set
normal

Tracking

(seamonkey2.52 fixed)

RESOLVED FIXED
seamonkey2.52
Tracking Status
seamonkey2.52 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1183962 removed the devtools.webide.widget.enabled preference. 

I am now seeing erros in the console because of this.

> Timestamp: 5/9/2017, 5:25:48 PM
> Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff 
> (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]
> Source File: chrome://navigator/content/webDeveloperOverlay.js
> Line: 187

One change to devtools/client/framework/devtools-browser.js needs to be ported.
Attachment #8865906 - Flags: review?(iann_bugzilla)
Comment on attachment 8865906 [details] [diff] [review]
1363422-webidewidgetpref.patch

LGTM r=me
Interesting about Bug 1356226, wonder what work we will need to do...
Attachment #8865906 - Flags: review?(iann_bugzilla) → review+
https://hg.mozilla.org/comm-central/rev/b38a1fb0d1ba725b44d291774837e4d68e0e65dd

devtools integration needs some other patches too. All what is needed is time and this ...
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
Botond you attached a devtools patch for mozilla files to a closed SeaMonkey bug and asked for review. Are you sure that is what you wanted?
Flags: needinfo?(botond)
Comment on attachment 8867419 [details]
Bug 1363422 - Prevent the maybe-hit region from growing too large (in terms of number of rectangles) in PaintedLayerData::AccumulateEventRegions().

Whoops. I made a typo in the bug number in the commit message. It was supposed to be bug 1363423. My bad!
Attachment #8867419 - Attachment is obsolete: true
Flags: needinfo?(botond)
Attachment #8867419 - Flags: review?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.