1363422 - Remove devtools.webide.widget.enabled pref from SeaMonkey after Bug 1183962.

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1183962 removed the devtools.webide.widget.enabled preference. 

I am now seeing erros in the console because of this.

> Timestamp: 5/9/2017, 5:25:48 PM
> Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff 
> (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]
> Source File: chrome://navigator/content/webDeveloperOverlay.js
> Line: 187

One change to devtools/client/framework/devtools-browser.js needs to be ported.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1363422-webidewidgetpref.patch

Comment 2

[Ian Neal]

Comment on attachment 8865906 [details] [diff] [review]
1363422-webidewidgetpref.patch

LGTM r=me
Interesting about Bug 1356226, wonder what work we will need to do...

Comment 3

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/b38a1fb0d1ba725b44d291774837e4d68e0e65dd

devtools integration needs some other patches too. All what is needed is time and this ...

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1363422 - Prevent the maybe-hit region from growing too large (in terms of number of rectangles) in PaintedLayerData::AccumulateEventRegions().

Review commit: https://reviewboard.mozilla.org/r/138952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138952/

Comment 5

[Frank-Rainer Grahl (:frg)]

Botond you attached a devtools patch for mozilla files to a closed SeaMonkey bug and asked for review. Are you sure that is what you wanted?

Comment 6

[Botond Ballo [:botond]]

Comment on attachment 8867419 [details]
Bug 1363422 - Prevent the maybe-hit region from growing too large (in terms of number of rectangles) in PaintedLayerData::AccumulateEventRegions().

Whoops. I made a typo in the bug number in the commit message. It was supposed to be bug 1363423. My bad!