Closed Bug 1363659 Opened 7 years ago Closed 7 years ago

Prevent mozilla::ipc::FatalError from mozilla::net::PNeckoChild::SendP*Constructor

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla55

Tracking Flags:

Tracking

Status

firefox55

---

fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

Details

(Whiteboard: [necko-active])

Attachments

(7 files)

neckoCrash 7 years ago Junior [inactive] 1011 bytes, patch	valentin : review+	Details \| Diff \| Splinter Review
cookieCrash 7 years ago Junior [inactive] 1.71 KB, patch	ehsan.akhgari : review+	Details \| Diff \| Splinter Review
dnsCrash 7 years ago Junior [inactive] 1.67 KB, patch	valentin : review+	Details \| Diff \| Splinter Review
dataCrash 7 years ago Junior [inactive] 1.50 KB, patch	valentin : review+	Details \| Diff \| Splinter Review
ftpCrash 7 years ago Junior [inactive] 3.85 KB, patch	valentin : review+	Details \| Diff \| Splinter Review
fileCrash 7 years ago Junior [inactive] 1.38 KB, patch	valentin : review+	Details \| Diff \| Splinter Review
httpCrash 7 years ago Junior [inactive] 2.45 KB, patch	u408661 : review+	Details \| Diff \| Splinter Review

Junior [inactive]

Assignee

Description

•

7 years ago

We already have Bug 1363472, Bug 1277582 and Bug 1359951.
Would like to handle SendP*Constructor under necko.

Junior [inactive]

Assignee

Comment 1

•

7 years ago

i.e., Handle all the cases 
https://searchfox.org/mozilla-central/search?q=SendP.*Constructor&case=false&regexp=true&path=netwerk

Only bugs in comment 0 are handled.

Junior [inactive]

Assignee

Updated

•

7 years ago

Depends on: 1363472, 1277582, 1359951

Junior [inactive]

Assignee

Comment 2

•

7 years ago

Not to have a check in WebSocketEventService since it's only used for debug.
https://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/netwerk/protocol/websocket/WebSocketEventListenerParent.cpp#26

Junior [inactive]

Assignee

Comment 3

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d1176a53df2c6491b360fc4e0e7739f1d862027

Junior [inactive]

Assignee

Comment 4

•

7 years ago

Attached patch neckoCrash — Details — Splinter Review

Attachment #8871656 - Flags: review?(valentin.gosu)

Junior [inactive]

Assignee

Comment 5

•

7 years ago

Attached patch cookieCrash — Details — Splinter Review

Attachment #8871658 - Flags: review?(ehsan)

Junior [inactive]

Assignee

Comment 6

•

7 years ago

Attached patch dnsCrash — Details — Splinter Review

Attachment #8871660 - Flags: review?(valentin.gosu)

Junior [inactive]

Assignee

Comment 7

•

7 years ago

Attached patch dataCrash — Details — Splinter Review

Attachment #8871661 - Flags: review?(valentin.gosu)

Junior [inactive]

Assignee

Comment 8

•

7 years ago

Attached patch ftpCrash — Details — Splinter Review

Attachment #8871662 - Flags: review?(valentin.gosu)

Junior [inactive]

Assignee

Comment 9

•

7 years ago

Attached patch fileCrash — Details — Splinter Review

Attachment #8871663 - Flags: review?(valentin.gosu)

Junior [inactive]

Assignee

Comment 10

•

7 years ago

Attached patch httpCrash — Details — Splinter Review

Attachment #8871664 - Flags: review?(hurley)

(no longer active)

Updated

•

7 years ago

Attachment #8871658 - Flags: review?(ehsan) → review+

u408661

Updated

•

7 years ago

Attachment #8871664 - Flags: review?(hurley) → review+

Valentin Gosu [:valentin] (he/him)

Updated

•

7 years ago

Attachment #8871656 - Flags: review?(valentin.gosu) → review+

Valentin Gosu [:valentin] (he/him)

Updated

•

7 years ago

Attachment #8871660 - Flags: review?(valentin.gosu) → review+

Valentin Gosu [:valentin] (he/him)

Updated

•

7 years ago

Attachment #8871661 - Flags: review?(valentin.gosu) → review+

Valentin Gosu [:valentin] (he/him)

Updated

•

7 years ago

Attachment #8871662 - Flags: review?(valentin.gosu) → review+

Valentin Gosu [:valentin] (he/him)

Updated

•

7 years ago

Attachment #8871663 - Flags: review?(valentin.gosu) → review+

Junior [inactive]

Assignee

Updated

•

7 years ago

Keywords: checkin-needed

Pulsebot

Comment 11

•

7 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2340b08f4f7
Ensure not sending necko IPC constructor when shutting down, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3b99c288e66
Ensure not sending cookie service constructor when shutting down, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad232f31e5a0
Ensure not sending dns request constructor when shutting down, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/8806b294e566
Ensure not sending data channel constructor when shutting down, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcbaf5f542b6
Ensure not sending IPC constructor in FTP channel when shutting down, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c6864de334
Ensure not sending file channel constructor when shutting down, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/4340666eb8e0
Ensure not sending IPC constructor in HTTP channel when shutting down, r=nwgh

Keywords: checkin-needed

Carsten Book [:Tomcat]

Comment 12

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/a2340b08f4f7
https://hg.mozilla.org/mozilla-central/rev/e3b99c288e66
https://hg.mozilla.org/mozilla-central/rev/ad232f31e5a0
https://hg.mozilla.org/mozilla-central/rev/8806b294e566
https://hg.mozilla.org/mozilla-central/rev/dcbaf5f542b6
https://hg.mozilla.org/mozilla-central/rev/f5c6864de334
https://hg.mozilla.org/mozilla-central/rev/4340666eb8e0

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox55: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla55

Shian-Yow Wu [:swu]

Updated

•

7 years ago