Closed Bug 1363876 Opened 8 years ago Closed 8 years ago

Enable async drawing for 64-bit builds in 54 and higher

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 1 obsolete file)

We just backed out async drawing from 54 for all builds due to the following bugs: bug 1359886 - Regression April 12th in accelerated Flash async plugin drawing use Bug 1334803 - Xfinity TV video playback fails in 64-bit builds of Firefox Bug 1348629 - Zero sized Flash content does not load on 64 bit Firefox The first is still being working on and represents a performance regression. The next two are Flash bugs which should be fixed in the Flash release slated for early June. Chris raised a great point today, that there's really no reason to hold up rolling async out to 64-bit. In those builds we still force windowless mode, which is a worse experience compared to async drawing + bug 1359886. Windowless also causes issues like bug 1317995! So I'm proposing landing a patch on 54 that enables async for 64-bit builds only and we let that roll out to release. Benjamin, do you have any concerns with this change?
Flags: needinfo?(benjamin)
No concerns; this makes sense. Although RT should also be aware since he's been sending the product updates for this.
Flags: needinfo?(benjamin)
Comment on attachment 8866796 [details] [diff] [review] prefs patch I checked the prefs in 32 and 64 bit try builds to be sure those ifdefs are working right, fyi.
Attachment #8866796 - Flags: review?(benjamin)
Attachment #8866796 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Needs rebasing.
Flags: needinfo?(jmathies)
Keywords: checkin-needed
Attached patch prefs patchSplinter Review
rebased for mc.
Attachment #8866796 - Attachment is obsolete: true
Flags: needinfo?(jmathies)
Attachment #8867698 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/723c7f7a8d67 Enable Flash async drawing for 64-bit release builds, starting with 54. r=bsmedberg
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8867698 [details] [diff] [review] prefs patch Approval Request Comment [Feature/Bug causing the regression]: async drawing feature, turning this back on for 64-bit builds. [User impact if declined]: the change addresses a number of problems with flash and 64-bit builds. [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: long standing feature enabled on nightly and beta in the past. [String changes made/needed]: none
Attachment #8867698 - Flags: approval-mozilla-beta?
Comment on attachment 8867698 [details] [diff] [review] prefs patch Enable async drawing for 64-bit. Beta54+. Should be in 54 beta 9.
Attachment #8867698 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: