If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

stylo: Initial value of mask-repeat should be repeat instead of no-repeat

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: xidorn, Assigned: cjku)

Tracking

(Blocks: 2 bugs)

53 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [stylo])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 months ago
This is revealed by test layout/style/test_computed_style.html that there is a difference between Stylo and Gecko that Gecko fails to serialize the computed value of mask shorthand there.

It is because Gecko checks whether all subproperties of mask except mask-image are initial for serializing the computed value [1].

This check fails for "mask: url(#mask)" because in Stylo, mask-repeat is set to "no-repeat" for initial, while Gecko checks it against "repeat".

The spec seems to agree with Servo that initial value of mask-repeat is "no-repeat", and it specially notes that its initial value is different from background-repeat (which is "repeat").

However, although Blink doesn't have mask-repeat, its initial value of -webkit-mask-repeat seems to be "repeat", which matches Gecko.

It is unclear to me whether we should change Gecko to match the spec (and Servo) or we should change Servo (and spec) to match Gecko and Blink.

[1] https://dxr.mozilla.org/mozilla-central/rev/3b96f277325747fe668ca8cd896d2f581238e4ee/layout/style/nsComputedDOMStyle.cpp#6361-6377
(Reporter)

Comment 1

4 months ago
CJ, what do you think about this?
Flags: needinfo?(cku)
Whiteboard: [stylo]
Per bug 1346193 the WG agreed to change the initial value to "repeat", but the spec change still hasn't been made yet.
(Reporter)

Comment 3

4 months ago
Ok, so we should change Stylo to match the resolution.
Flags: needinfo?(cku)
Summary: Initial value of mask-repeat should be no-repeat rather than repeat → stylo: Initial value of mask-repeat should be repeat instead of no-repeat
(Assignee)

Updated

4 months ago
Assignee: nobody → cku
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8867611 - Flags: review?(cam)

Comment 5

4 months ago
mozreview-review
Comment on attachment 8867611 [details]
Bug 1364273 - Change mask-repeat initial value from no-repeat to repeat.

https://reviewboard.mozilla.org/r/139176/#review142402

::: commit-message-e66de:1
(Diff revision 1)
> +Bug 1364273 - Change mask-repeat initial value from no-preat to repeat.

no-repeat
Attachment #8867611 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 7

4 months ago
https://github.com/servo/servo/pull/16864
(Assignee)

Updated

4 months ago
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8867611 - Attachment is obsolete: true
(Assignee)

Updated

4 months ago
Attachment #8867976 - Flags: review?(cku)
(Assignee)

Comment 9

4 months ago
mozreview-review
Comment on attachment 8867976 [details]
Bug 1364273 - (followup) update stylo-failures.md to reduce failure count of mask.

https://reviewboard.mozilla.org/r/139514/#review142858
Attachment #8867976 - Flags: review?(cku) → review+

Comment 10

4 months ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6028e667129f
(followup) update stylo-failures.md to reduce failure count of mask. r=cjku

Comment 11

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6028e667129f
You need to log in before you can comment on or make changes to this bug.