136443 - Stop button not working in mailnews

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P1)

Description

[Navin Gupta]

Stop doesn't stop any mailnews operations

Comment 1

[Nicholas Allen]

This has been going on since at least yesterday since bug 136243 seems to be 
the same thing.

Comment 2

[Navin Gupta]

*** Bug 136243 has been marked as a duplicate of this bug. ***

Comment 3

[David :Bienvenu]

is the stop button simply not hooked up anymore? could it have been all the ui
changes that went in? Or does stop not work with loadgroups anymore?

Comment 4

[Navin Gupta]

I don't see uriLoader::Stop getting called for mailnews. It does get
called for browser though. I'm still investigating...

Comment 5

[Navin Gupta]

looks like the ui changes broke it, I will have to dig deeper. 

Comment 6

[Navin Gupta]

Attachment: proposed fix, v1

Call the function in the oncommand handler. I'll see if there is another way
to do it though goDoCommand('cmd_stop') was not calling MsgStop()

Comment 7

[David :Bienvenu]

Looks like Blake made this change on purpose. Cc'ing him to see how he thinks
this should work. Perhaps we should be calling MsgStop() when we handle the
cmd_stop command.

Comment 8

[Blake Ross]

Yeah, the command's oncommand should call MsgStop() or that should be done from
wherever mailnews handles its commands.

Comment 9

[Navin Gupta]

Attachment: proposed fix, v2

Calling MsgStop(); directly works. Blake, can you review ? thx.

Comment 10

[Blake Ross]

Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

r=blake

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

sr=sspitzer

Comment 12

[(not reading, please use [e-mail] instead)]

thanks for fixing this, navin.

Comment 13

[Navin Gupta]

fixed

Comment 14

[Navin Gupta]

opening so that it can be checked on mozilla 1.0 branch

Comment 15

[scottputterman]

nominating with adt1.0.0

Comment 16

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on behalf of the ADT) for checkin to the 1.0 branch. Pls check it
into both the branch and the trunk. Thanks!

Comment 17

[Asa Dotzler [:asa]]

We should definitely get this into the branch before RC1. 

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 19

[Navin Gupta]

fixed on branch too.

Comment 20

[Karen Huang]

Change platform & OS to All.
Verified on all platforms for the 1.0.0 branch builds:
Windows 04-13-08-1.0.0
Linux 04-14-09-1.0.0
Mac 04-15-05-1.0.0
Mac OSX 04-15-05-1.0.0

This bug has been verified on 1.0.0, but will leave status "as is" until I 
verify on trunk build later.
Adding "verified1.0.0" for the keywords.

Comment 21

[Karen Huang]

*** Bug 143042 has been marked as a duplicate of this bug. ***

Comment 22

[Karen Huang]

From Comment#20, this bug has been verified on Branch build for all the
platforms already.
In order to close this bug, I verify this bug on all the platforms for current
branch & trunk builds again:
Current Branch builds:
Windows 07-18-08-1.0 -> Passed
Linux 07-18-07-1.0 -> Passed
Mac 07-18-05-1.0 -> Passed
Current Trunk builds
Windows 07-18-13-trunk -> Passed
Linux 07-18-08-trunk -> Passed
Mac 07-18-08-trunk -> Passed
Marking as verified.