Closed Bug 136443 Opened 22 years ago Closed 22 years ago

Stop button not working in mailnews

Categories

(MailNews Core :: Networking, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: naving, Assigned: naving)

References

Details

(Keywords: regression, Whiteboard: [adt1]verified on branch builds already)

Attachments

(1 file, 1 obsolete file)

Stop doesn't stop any mailnews operations
Keywords: nsbeta1, regression
Severity: normal → critical
Priority: -- → P1
This has been going on since at least yesterday since bug 136243 seems to be 
the same thing.
*** Bug 136243 has been marked as a duplicate of this bug. ***
is the stop button simply not hooked up anymore? could it have been all the ui
changes that went in? Or does stop not work with loadgroups anymore?
I don't see uriLoader::Stop getting called for mailnews. It does get
called for browser though. I'm still investigating...
looks like the ui changes broke it, I will have to dig deeper. 
Attached patch proposed fix, v1 (obsolete) — Splinter Review
Call the function in the oncommand handler. I'll see if there is another way
to do it though goDoCommand('cmd_stop') was not calling MsgStop()
Looks like Blake made this change on purpose. Cc'ing him to see how he thinks
this should work. Perhaps we should be calling MsgStop() when we handle the
cmd_stop command.
Yeah, the command's oncommand should call MsgStop() or that should be done from
wherever mailnews handles its commands.
Attached patch proposed fix, v2Splinter Review
Calling MsgStop(); directly works. Blake, can you review ? thx.
Attachment #78437 - Attachment is obsolete: true
Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

r=blake
Attachment #78647 - Flags: review+
Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

sr=sspitzer
Attachment #78647 - Flags: superreview+
thanks for fixing this, navin.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
opening so that it can be checked on mozilla 1.0 branch
Status: RESOLVED → REOPENED
Keywords: adt1.0.0
Resolution: FIXED → ---
nominating with adt1.0.0
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt1]
adt1.0.0+ (on behalf of the ADT) for checkin to the 1.0 branch. Pls check it
into both the branch and the trunk. Thanks!
Keywords: adt1.0.0adt1.0.0+
We should definitely get this into the branch before RC1. 
Blocks: 134771
Keywords: mozilla1.0+
Whiteboard: [adt1] → [adt1]awaiting drivers approval
Comment on attachment 78647 [details] [diff] [review]
proposed fix, v2

a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #78647 - Flags: approval+
fixed on branch too.
Status: REOPENED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Change platform & OS to All.
Verified on all platforms for the 1.0.0 branch builds:
Windows 04-13-08-1.0.0
Linux 04-14-09-1.0.0
Mac 04-15-05-1.0.0
Mac OSX 04-15-05-1.0.0

This bug has been verified on 1.0.0, but will leave status "as is" until I 
verify on trunk build later.
Adding "verified1.0.0" for the keywords.

Keywords: verified1.0.0
OS: Windows NT → All
Hardware: PC → All
Whiteboard: [adt1]awaiting drivers approval → [adt1]awaiting drivers approval, verified on branch builds already
Whiteboard: [adt1]awaiting drivers approval, verified on branch builds already → [adt1]verified on branch builds already
*** Bug 143042 has been marked as a duplicate of this bug. ***
From Comment#20, this bug has been verified on Branch build for all the
platforms already.
In order to close this bug, I verify this bug on all the platforms for current
branch & trunk builds again:
Current Branch builds:
Windows 07-18-08-1.0 -> Passed
Linux 07-18-07-1.0 -> Passed
Mac 07-18-05-1.0 -> Passed
Current Trunk builds
Windows 07-18-13-trunk -> Passed
Linux 07-18-08-trunk -> Passed
Mac 07-18-08-trunk -> Passed
Marking as verified.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: