Closed Bug 1364504 Opened 8 years ago Closed 7 years ago

Handle device resets of ANGLE on Windows

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox62 --- fixed

People

(Reporter: rhunt, Assigned: sotaro)

References

(Depends on 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 8 obsolete files)

patch - Handle device resets of ANGLE on Windows
12.47 KB, patch
nical
: review+
Details | Diff | Splinter Review
It doesn't look like we are handling device resets with WebRender on Windows. It looks like ANGLE supports EXT_robustness, and so we can probably use GetGraphicsResetStatusEXT to detect a reset. I am not sure what work is necessary once we detect a reset. I think we can use the device reset path from bug 1363126, but this all needs more investigation.
Assignee: nobody → sotaro.ikeda.g
Depends on: 1354411
Depends on: 1387920
Depends on: 1395107
:milan, can you increase this bug's priority? This bug blocks Bug 1365264, it is P1.
Flags: needinfo?(milan)
Blocks: stage-wr-trains
No longer blocks: stage-wr-year
Flags: needinfo?(milan)
Priority: P3 → P1
Attached patch wip (obsolete) — — Splinter Review
Needs to add handling of updating EGLDisplay of ANGLE EGL.
Depends on: 1419293
Blocks: 1437442
Depends on: 1438456
Depends on: 1441056
Summary: Handle device resets with ANGLE on Windows → Handle device resets of ANGLE on Windows
No longer depends on: 1438456
By Bug 1438456 Comment 7, I am going to change the way of handling device reset. I am going to handle device reset by resetting GPU process for now.
Depends on: 1451183
(In reply to Sotaro Ikeda [:sotaro] from comment #6) > By Bug 1438456 Comment 7, I am going to change the way of handling device > reset. I am going to handle device reset by resetting GPU process for now. Hmm, it does not work in all situations. Instead, I am going to address capability of resetting GLLibraryEGL state bug 1451183
Depends on: 1188006
It seems that normal gfx layers still has problem related to TDR.
Attachment #8981790 - Attachment is patch: true
Attachment #8981790 - Attachment mime type: text/x-patch → text/plain
Attachment #8981790 - Attachment is obsolete: true
Depends on: 1466454
Attachment #8973931 - Attachment is obsolete: true
Attachment #8983328 - Flags: review?(nical.bugzilla)
Attachment #8983328 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aea9119b2797 Handle device resets of ANGLE on Windows r=nical
https://hg.mozilla.org/mozilla-central/rev/aea9119b2797
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Depends on: 1468675
Depends on: 1469480
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: