Closed Bug 1365264 Opened 9 years ago Closed 8 years ago

Ensure content process rendering reinit works well with webrender

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected

People

(Reporter: kats, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve] [gfx-noted])

We might occasionally get GPU process crashes with webrender. In those cases we need to make sure the reinit codepath works. Right now we can end up with a chain of crashes because the reinit codepath itself crashes (see bug 1365009 comment 7). I suspect bug 1364504 will be a part of this solution, but probably not the whole thing.
I ran with the GPU process and WebRender enabled on Linux, and then killed the GPU process to see how we would handle the restart. It seems to work fine. I also killed the GPU process enough times to fall back to basic compositor, and that also seemed to work fine. So I'm not really sure why the reinit codepath is crashing as in bug 1350408.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1) > I'm not really sure why the reinit codepath is crashing as in bug 1350408. It happened when GPU process was crashed during creating WebRender in GPU process.
Bug 1354411 is going to address a part of the problem.
Depends on: 1354411
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Priority: P2 → P3
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
Assignee: nobody → sotaro.ikeda.g
Device reset is handled now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.