Closed Bug 1395107 Opened 2 years ago Closed 2 years ago

Create GL context for WebRender with CompositorDevice applied

Categories

(Core :: Graphics: WebRender, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox59 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve])

Attachments

(2 files, 9 obsolete files)

1.56 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review
5.35 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
It makes thing simpler if CompositorDevice is applied to GL context for WebRender.
Blocks: 1364504
Assignee: nobody → sotaro.ikeda.g
Attached patch wip patch (obsolete) — Splinter Review
Attachment #8902620 - Attachment is obsolete: true
Depends on: 1395417
Attached patch wip patch (obsolete) — Splinter Review
Attachment #8902980 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [wr-mvp]
Target Milestone: --- → mozilla57
Attached patch wip patch (obsolete) — Splinter Review
Rebased.
Attachment #8902990 - Attachment is obsolete: true
Depends on: 1403049
Depends on: 1403114
Attached patch wip patch (obsolete) — Splinter Review
Attachment #8911028 - Attachment is obsolete: true
No longer depends on: 1403114
Depends on: 1403114
No longer depends on: 1403114
Whiteboard: [wr-mvp] → [wr-reserve]
Attachment #8913065 - Attachment is obsolete: true
ANGLE does not enable "present path fast" even with EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE if EGL_PLATFORM_DEVICE_EXT is used. This patch makes "present path fast" valid with EGL_PLATFORM_DEVICE_EXT
Attachment #8940039 - Attachment is obsolete: true
Attachment #8940068 - Flags: review?(jgilbert)
Attachment #8940073 - Flags: review?(jgilbert)
Attachment #8940068 - Flags: review?(jgilbert) → review+
Comment on attachment 8940073 [details] [diff] [review]
patch part 2 - Create GL context for WebRender with CompositorDevice applied

Review of attachment 8940073 [details] [diff] [review]:
-----------------------------------------------------------------

This is likely to break non-e10s+webrender, if we care about that.
Attachment #8940073 - Flags: review?(jgilbert) → review+
We do not support non-e10s+webrender with ANGLE for now.
Depends on: 1371190
Fixed build failure on linux.
Attachment #8940073 - Attachment is obsolete: true
Attachment #8940937 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d88099a3a53a
Create GL context for WebRender with CompositorDevice applied r=jgilbert
https://hg.mozilla.org/mozilla-central/rev/d88099a3a53a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.