Closed Bug 136497 Opened 23 years ago Closed 22 years ago

carbonize xpicleanup

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dprice, Assigned: dprice)

References

Details

(Keywords: platform-parity, Whiteboard: [adt1][ETA4-17])

Attachments

(2 files)

patch
175.06 KB, patch
mozeditor
: review+
dveditz
: superreview+
jesup
: approval+
Details | Diff | Splinter Review
adds resource to disable the classic environment
4.93 KB, patch
sfraser_bugs
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
XPI cleanup isn't being built for OS X. There's no project and the code hasn't been 'carbonized'
Blocks: 123654
No longer blocks: 123654
Keywords: nsbeta1
Syd: this should be adt1 or 2 -- without the cleanup utility users will eventually end up in a non-running state if they install things. This blocks adt1 bug 123654
Blocks: 123654
Attached patch patch — — Splinter Review
new carbon targets changes to MozillaBuildList.pm changes to InstallCleanupMac.cpp
Attachment #78478 - Flags: review+
Comment on attachment 78478 [details] [diff] [review] patch I was able to build and run with Dave's patch. Using said build to make this comment. r=jfrancis
Comment on attachment 78478 [details] [diff] [review] patch sr=dveditz
Attachment #78478 - Flags: superreview+
Carrying keywords over from bug 123654
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1+, pp
Whiteboard: [adt1]
*** Bug 123654 has been marked as a duplicate of this bug. ***
Keywords: adt1.0.0
Comment on attachment 78478 [details] [diff] [review] patch a=rjesup@wgate.com for checkin to branch and trunk
Attachment #78478 - Flags: approval+
adding adt1.0.0+ on behalf of the adt. Please check this into the 1.0 branch as soon as possible.
Keywords: adt1.0.0 → adt1.0.0+
Whiteboard: [adt1] → [adt1][ETA4-17]
This hit the trunk today, it will land on the branch when it opens.
landed on the branch, marking fixed and fixed1.0.0
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
Build: 2002-04-22-03-trunk(Mac 10.x), 2002-04-19-05-1.0.0(MAC 10.x) Verfied on both trunk and branch. Text and binary files in use do get properly replaced. Marking Verified! Adding keyword, verified1.0.0.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.0 → verified1.0.0
reopening, we needed to add a resource to prevent the classic environment from launching.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
How was this bug every verified if XPICleanup fired up Classic?
Comment on attachment 95203 [details] [diff] [review] adds resource to disable the classic environment r=sfraser
Attachment #95203 - Flags: review+
Comment on attachment 95203 [details] [diff] [review] adds resource to disable the classic environment sr=dveditz
Attachment #95203 - Flags: superreview+
on the trunk
marking fixed this time
Status: REOPENED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
*** Bug 164850 has been marked as a duplicate of this bug. ***
v
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
No longer blocks: 2.51BulkMalfunctions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: