1365256 - disabled addons are not actually disabled, these addons are loaded.

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open Addons Manager
2. Disable some addons and Restart
3. Observe Addons Manager
4. Disabled addon is actually disabled or not.

Actual Results:
Disabled addons are not actually disabled, these addons are loaded.

Expected Results:
Disabled addons should not be loaded.


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9730f88bdbd3d167d3c5b1acb0618cd2533bb570&tochange=9795dacd97e1dafdfc23ad1f2188cca3c2b9f45e

Regressed by: Bug 1358846

Comment 1

[Alice0775 White]

Still Reproduced:
https://hg.mozilla.org/mozilla-central/rev/3e166b6838931b3933ca274331f9e0e115af5cc0
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170515162323

So, Bug 1364878 does not fix this problem

Comment 2

[Alice0775 White]

Attachment: screenshot

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Is it doable to backout bug 1358846 at this point so we can get nightlies unblocked?

Comment 4

[Jorg K (CEST = GMT+2)]

Is this not a duplicate of bug 1364878? That one is fixed already.

Comment 5

[Alice0775 White]

(In reply to Jorg K (GMT+2) from comment #4)
> Is this not a duplicate of bug 1364878? That one is fixed already.

See comment #1, Bug 1364878 does not fix this problem.

Comment 6

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I can confirm this bug on Windows 7 x64, with the following scenario:
1. Install an old version of Nightly - e.g. Nightly 54 from February 27
2. Go to https://addons.mozilla.org/en-US/firefox/addon/dom-inspector-6622/?src=ss
3. Install DOM Inspector (alternately you can also install other add-ons - I've also installed uBlock and Video DownloadHelper)
4. Restart Firefox -> about:addons will show the installed add-ons as enabled
5. Close Firefox
6. Install the latest Nightly (in my case it was Nightly 55 from May 15 - BuildID=20170515030205)
7. Start the latest Nightly, with the same profile used for the previous steps, and go to about:addons

Results:
- all add-ons appear as disabled, but only the DOM Inspector add-on does NOT display the "Enable" button (see florin_1.png attached)
- there is no trace of add-ons being enabled (no buttons in the toolbar), except for DOM Inspector which can still be found in the Web Developer menu, and also can be opened (see florin_2.png attached)

It seems this issue only affects some Add-ons (in this case DOM Inspector), while others are correctly disabled.

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: florin_1.png

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: florin_2.png

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b8e9b674033b
Don't register chrome for disabled, restartful add-ons. r=aswan a=RyanVM CLOSED TREE

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Julien pointed out on IRC that people are actually interested in confirming the behaviour after the backout. So I've retried the scenario from comment 6, but this time instead of using the latest Nightly I used the build with the backout (from https://hg.mozilla.org/mozilla-central/rev/3e166b6838931b3933ca274331f9e0e115af5cc0 - or - https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32/1494890603/).

Results:
- Only the DOM Inspector add-on is disabled, and does NOT display the "Enable" button (see florin_backout_1.png attached)
- The DOM Inspector add-on, while showing as disabled, can still be found in the Web Developer menu, and can be opened (see florin_backout_2.png attached). The other add-ons show as enabled and are functional.

Comment 11

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: florin_backout_1.png

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: florin_backout_2.png

Comment 13

[DJ-Leith]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #10)

> Results:
> - Only the DOM Inspector add-on is disabled, and does NOT display the
>     "Enable" button (see florin_backout_1.png attached)
> - The DOM Inspector add-on, while showing as disabled, can still be found
>     in the Web Developer menu, and can be opened
>     (see florin_backout_2.png attached). The other add-ons show as enabled and
>     are functional.

Florin, what happens if, using "about:config",
"extensions.allow-non-mpc-extensions" is set to "true"?

DJ-Leith

Comment 14

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-05-17_1930.png

(In reply to DJ-Leith from comment #13)
> Florin, what happens if, using "about:config",
> "extensions.allow-non-mpc-extensions" is set to "true"?
> 
> DJ-Leith

All add-ons are enabled while using extensions.allow-non-mpc-extensions set to true including the non-mpc ones. The Firefox build 55.0a1 was updated from 2017-02-27 to 2017-05-17 under Windows 10 64-bit. See attached screenshot

Comment 15

[avada]

This didn't stop happening in safe mode. The addons are shown to be disabled, but in fact they're loaded.

Comment 16

[Alice0775 White]

(In reply to avada from comment #15)
> This didn't stop happening in safe mode. The addons are shown to be
> disabled, but in fact they're loaded.

Filed bug 1365706

Comment 17

[Vasilica Tamas, QA [:vtamas]]

This issue is no longer reproducible on Firefox 56.0a1 (2017-07-23) and Firefox 55.0b11 (20170720101430) under Windows 10 64-bit and Ubuntu 16.04 32-bit. All disabled add-ons are no longer loaded. Based on this testing I am marking this bug as Verified.