1365319 - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-plugins-policy.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-plugins-policy.js | test-plugins-policy.js::test_3paneWindowAllowed
 
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-plugins-policy.js | test-plugins-policy.js::test_checkStandaloneMessageWindowAllowed

First seen 2017-05-16:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=97e9e426dc7c9c07863cbc8cd3c75fc6063160af

Log at
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-macosx64/1494939803/comm-central_yosemite_r7_test-mozmill-bm132-tests1-macosx-build5.txt.gz
says:
07:34:48     INFO -  SUMMARY-UNEXPECTED-FAIL | test-plugins-policy.js | test-plugins-policy.js::test_3paneWindowAllowed
07:34:48     INFO -    EXCEPTION: Plugin has been unexpectedly blocked in message content
07:34:48     INFO -      at: test-plugins-policy.js line 121
07:34:48     INFO -         addMsgToFolderAndCheckContent test-plugins-policy.js:121 11
07:34:48     INFO -         test_3paneWindowAllowed test-plugins-policy.js:208 3
07:34:48     INFO -         Runner.prototype.wrapper frame.js:585 9
07:34:48     INFO -         Runner.prototype._runTestModule frame.js:655 9
07:34:48     INFO -         Runner.prototype.runTestModule frame.js:701 3
07:34:48     INFO -         Runner.prototype.runTestDirectory frame.js:525 7
07:34:48     INFO -         runTestDirectory frame.js:707 3
07:34:48     INFO -         Bridge.prototype._execFunction server.js:179 10
07:34:48     INFO -         Bridge.prototype.execFunction server.js:183 16
07:34:48     INFO -         Session.prototype.receive server.js:283 3
07:34:48     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3
07:34:48     INFO -  SUMMARY-UNEXPECTED-FAIL | test-plugins-policy.js | test-plugins-policy.js::test_checkStandaloneMessageWindowAllowed
07:34:48     INFO -    EXCEPTION: Plugin has been unexpectedly blocked in standalone window
07:34:48     INFO -      at: test-plugins-policy.js line 141
07:34:48     INFO -         checkStandaloneMessageWindow test-plugins-policy.js:141 11
07:34:48     INFO -         test_checkStandaloneMessageWindowAllowed test-plugins-policy.js:212 3
07:34:48     INFO -         Runner.prototype.wrapper frame.js:585 9
07:34:48     INFO -         Runner.prototype._runTestModule frame.js:655 9
07:34:48     INFO -         Runner.prototype.runTestModule frame.js:701 3
07:34:48     INFO -         Runner.prototype.runTestDirectory frame.js:525 7
07:34:48     INFO -         runTestDirectory frame.js:707 3
07:34:48     INFO -         Bridge.prototype._execFunction server.js:179 10
07:34:48     INFO -         Bridge.prototype.execFunction server.js:183 16
07:34:48     INFO -         Session.prototype.receive server.js:283 3
07:34:48     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3

M-C last good: 5e81f95116344b68975ac5aba30a8bb9ee
M-C first bad: 49365d675cbb2a8368cda3e4858a2a0d06

Range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e81f95116344b68975ac5aba30a8bb9ee&tochange=49365d675cbb2a8368cda3e4858a2a0d06

This looks like bug 1335475. Benjamin, I saw that you introduced pref "plugins.http_https_only":
https://hg.mozilla.org/mozilla-central/rev/8068fb1cc45e#l5.12

Should we set this in TB to false in general or perhaps only for this test?

We already have preference mailnews.message_display.allow_plugins to allow or disallow plugins in massages.

Comment 1

[Benjamin Smedberg]

I would recommend removing support for the mailnews.message_display.allow_plugins pref altogether. Plugins are a footgun and nobody uses them legitimately in email messages. Otherwise, do what you need to do.

Comment 2

[Jorg K (CEST = GMT+2)]

Magnus, this is more or less your baby, having JS and plug-ins allowed in non-messages, like feed displays, and having them disabled in messages.

Would you like to follow Benjamin's advice to disallow them in messages for good? That would mean to remove the tests that fail now and also remove the preference and use 'false' instead, for example here:
https://dxr.mozilla.org/comm-central/rev/fb25c9d0f7ba7d9b788a801a47f81d4536d53ab0/mailnews/base/src/nsMsgContentPolicy.cpp#934

What's the reason for that preference? I didn't know of its existence, so I don't know of a case where it would have been useful.

I will disable the tests for now as a bustage fix. I'll let you decide whether we want to maintain the preference make the tests pass, or have the tests permanently removed.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1365319-disaple-plugin-tests.patch

https://hg.mozilla.org/comm-central/rev/a09ebe0269abee8765beb01e997ecfa6dff01372

Landed as bustage fix while we decide which way we want to go.

Note that disabling the tests doesn't compromise any security. Quite the opposite, plugins are currently not allowed in mail messages, no matter what ;-)

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1365319-disable-plugin.patch

Complete removal looks like this.

Comment 5

[Magnus Melin [:mkmelin]]

Yeah plugins are almost dead even in the browser, so let's just remove it.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/5e8c500f55ff1f827bc4297304e577137a0ff2c1

Comment 7

[Joe Sabash [:JoeS1]]

Wow, that was a quick decision. I really don't know what the usage of plugins is today, but a few years back there was a entire "culture" dedicated to Multimedia and plugins. Mostly Newsgroups like "Netscape.test.multimedia" and others when Netscape hit the crapper. There is still Mozilla.test.multimedia newsgroup, but little activity. And what about ecard emails, do they depend on plugins ? I'm not sure. Please keep this in Trunk only until we understand the over all impact.

Comment 8

[Magnus Melin [:mkmelin]]

Bug 1317856 is making even Flash click-to-play in the browser, so no designer in their right mind would use a plugin to deliver content anymore. IIRC click-to-play doesn't even work in Thunderbird.

Comment 9

[Jorg K (CEST = GMT+2)]

Two things: I tried embedded a YouTube video and that fails due to missing JS in messages. Greeting cards just use links, at least the few received ones I inspected.

Besides, I don't think anyone even knew the preference. This page http://kb.mozillazine.org/Plugin_support_in_Thunderbird needs to be corrected now.