1365582 - Audio&Video playback does not pause when Firefox is closed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Device: 
 - Nexus 5 (Android 6.0.1);
 - Galaxy Note 5 (Android 5.1).
Build:
 - Nightly 55.0a1 (2017-05-17);

Steps to reproduce:
1. Open Firefox and go to: https://goo.gl/49FJnb;
2. After video starts playing open task view and close Firefox;

Expected result:
 Audio playback should stop since Firefox has been closed.

Actual result:
 Audio playback does not stop. The user has to open Firefox and close it again in order to fix the issue.

Notes:
 Video: https://goo.gl/aDZe3H

Comment 1

[Blake Wu [:bwu][:blakewu]]

Bogdan,
Thanks for firing this bug. I can repro this bug on my Pixel wit the latest nightly, but not on the previous nightly. This regression should be introduced recently.   
Could you help find out the regression window?
Thanks.

Comment 2

[Bogdan Surd, QA [:bsurd, NI]]

Sure thing Blake,

Here is the reggresionwindow:
First known bad build: 2017-05-14
Last known good build: 2017-05-11
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=838652a84b76c273e084d0705f3f4f3be89520a8&tochange=73b3fc64525b6816842c737e104ef2ac5482d217

Notes:
 There were no Nightly builds in 12-13.

Comment 3

[Bogdan Surd, QA [:bsurd, NI]]

Hello again,

 My bad there was a Nightly build in 13, I've just missed it in the archive.
Updated window:
First known bad build: 2017-05-14
Last known good build: 2017-05-13
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=838652a84b76c273e084d0705f3f4f3be89520a8&tochange=73b3fc64525b6816842c737e104ef2ac5482d217

Comment 4

[John Lin [:jhlin][:jolin]]

I can reproduce it on Pixel.

The issue is not directly related to media. From what I observed, in good version, SIGKILL(9) was sent and the whole browser is killed, but in bad version there is no signal sent.

Jim, you made some changes to the shutdown code in bug 1362191. Could it be the cause?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Before bug 1362191, we always killed our own process when BrowserApp is destroyed. We no longer do that after bug 1362191, and we now rely on Android to kill our process. However, in this case the media control service is blocking Android from killing the Fennec process, so I think the best fix is to have media control service not block us from being killed by Android.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Stop MediaControlService on task removal (v1)

Stop the media control service when our task is removed, so that the
service doesn't block Android from killing our process.

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8869573 [details] [diff] [review]
Stop MediaControlService on task removal (v1)

Review of attachment 8869573 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2692d96a53e
Stop MediaControlService on task removal; r=ahunt

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2692d96a53e

Comment 10

[Bogdan Surd, QA [:bsurd, NI]]

Hello,

 I have verified this and can confirm it is properly fixed.