1365705 - Sidebar header has a dark background and dark text with the dark compact theme installed (win10)

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[alex_mayorga]

¡Hola!

The sidebar header switcher from https://bugzilla.mozilla.org/show_bug.cgi?id=1355324 is is almost impossible to read when using the dark theme, see https://bugzilla.mozilla.org/attachment.cgi?id=8868634

¡Gracias!
Alex

Comment 1

[Jan Sonntag]

I can confirm this behaviour using the Dark Fox theme. When I hover the URL bar, it becomes grey and hard to read.

Comment 2

[Brian Grinstead [:bgrins]]

Hi Alex, what operating system are you seeing this on?

Comment 3

[alex_mayorga]

¡Hola Brian!

This is on Windows 10.

¡Gracias!
Alex

Comment 4

[Brian Grinstead [:bgrins]]

Going to make a decision on whether this should be a dark background with light text, or a light background with dark text in https://bugzilla.mozilla.org/show_bug.cgi?id=1365807#c3.

Comment 5

[Brian Grinstead [:bgrins]]

Based on the decision in Bug 1365807, we are going to change the background to be light instead of making the text light

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1365705 - Remove Windows compact theme specific styling for sidebar;

Review commit: https://reviewboard.mozilla.org/r/142816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142816/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8871338 [details]
Bug 1365705 - Remove Windows compact theme specific styling for sidebar;

https://reviewboard.mozilla.org/r/142816/#review146842

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c7fd053fa3
Remove Windows compact theme specific styling for sidebar;r=dao

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7c7fd053fa3

Comment 10

[Anika Alam Raha]

I have reproduced this bug with Nightly 55.0a1 (2017-05-17) on Windows 8 (64 bit).

This bug's fix is verified on Latest Nightly 55.0a1.


Build ID : 20170608030205
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]

Comment 11

[u554753]

Attachment: Sidebar Dark Text Issue.png

I'm still seeing this issue with the following user agents:
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

The text with Bookmarks sidebar is still dark and hard to read with the Dark Compact theme installed via the Customize window. Screenshot attached.

Comment 12

[:Gijs (he/him)]

Hi Grover,

Can you check if this was fixed on those platforms in the first nightly this landed in, probably 2017-05-27 ? I suspect this regressed because of bug 1367242. If the patch worked originally, I guess it might be helpful to have a new bug to fix this a second time, as in that case the original fix would still be on 55 beta and working there (which would be good to doublecheck, too).

Comment 13

[Dão Gottwald [:dao]]

Filed bug 1376109.

Comment 14

[u554753]

Marking as Verified.