Closed
Bug 1366298
Opened 8 years ago
Closed 7 years ago
fluent.migrate.transforms.PLURAL should have tests with more than one output variant
Categories
(Localization Infrastructure and Tools :: Fluent Migration, enhancement)
Localization Infrastructure and Tools
Fluent Migration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: stas)
Details
Attachments
(1 file)
Right now, all the tests in https://github.com/projectfluent/python-fluent/blob/master/tests/migrate/test_plural.py create at most two plural forms in the generated FTL.
We should test the other code paths, too.
|
Assignee | |
Updated•8 years ago
|
Blocks: fluent.migrate
|
|
Assignee | |
Comment 1•7 years ago
|
||
I added tests for languages with a single plural category (e.g. Turkish) as well as those with many more than English (e.g. Polish). I introduced a special case for languages with one plural category: they can have their translations migrated directly to a single Pattern rather than a SelectExpression with one variant.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Axel approved this PR in GitHub and I landed it in https://github.com/projectfluent/python-fluent/commit/3d7b8384a423f9a28ac816855c4ee7455f139b58.
Axel also filed bug 1415555 to refactor test_plural at large and make it easier to understand. Let's continue the discussion there.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8926344 -
Flags: review?(l10n)
|
|
Assignee | |
Updated•7 years ago
|
No longer blocks: fluent.migrate
Component: Python Library → Fluent Migration
Product: L20n → Localization Infrastructure and Tools
You need to log in
before you can comment on or make changes to this bug.
Description
•