1366700 - Crash [@ mozilla::gl::GLContextEGLFactory::Create ]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170521100319

Steps to reproduce:

(In reply to Kartikaya Gupta (email:[e-mail]) from bug 1341478 comment #4)
> (In reply to Darkspirit from bug 1341478 comment #3)
> > Please consider to reopen this bug.
> 
> Let's open a new bug for the crash you are seeing. This one was filed for
> Android, and the one you are seeing is in a webrender codepath which is
> different although the signature is the same.

Windows 10 x64: crash while doing a Radeon RX480 driver update. (After my whole desktop turned black for a second when windows activated the new driver).
gpu process force-enabled, webrender enabled, hardware accelleration (force-)enabled where possible

Meldungs-ID 	Sendedatum
bp-897e9aee-9f80-435d-a90f-9acf90170521  21.05.2017	15:09
= [@ mozilla::gl::GLContextEGLFactory::Create ]
= this bug

bp-8177c9fe-a27e-4313-9276-30e500170521	21.05.2017	15:08
= [@ mozilla::layers::PWebRenderBridgeChild::SendCreate ]
= bug 1350408

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

This is #10 top crash for 20170904 nightly.

mozilla::gl::GLContextEGLFactory::Create
mozilla::gl::GLContextProviderEGL::CreateForCompositorWidget
mozilla::wr::NewRenderer::Run
mozilla::wr::RenderThread::RunEvent
mozilla::detail::RunnableMethodImpl<T>::Run
MessageLoop::DoWork
base::MessagePumpDefault::Run
MessageLoop::RunHandler
MessageLoop::Run
base::Thread::ThreadMain
`anonymous namespace'::ThreadFunc
BaseThreadInitThunk
RtlUserThreadStart

Comment 2

[Calixte Denizet (:calixte)]

There are 646 crashes in nightly 57 for signature "mozilla::gl::GLContextEGLFactory::Create" (see [1]).
This crash appeared in nightly 55 with buildid 20170330030213.
There are no crash in beta 56 (even if there are in nightly 56) and in release 55.
In analyzing the backtrace, the bug may have been introduced by patch [2] to fix bug 1323316.
:sotaro, could you investigate please ?

[1] http://bit.ly/2jpR0XM
[2] https://hg.mozilla.org/mozilla-central/rev?node=69a8dd0935e25869d9f33440d92f317535843e09

Comment 3

[Sotaro Ikeda [:sotaro]]

I take a look.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove MOZ_CRASH in GLContextEGLFactory::Create

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be3d682f4a8aa8355adc4fac91d9ed24a954cd7e

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I guess while you're doing this, can you also remove the "\n" from the rest of the MOZ_CRASHes in this file? Then we can dupe bug 1400070 to this one.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Sotaro, is this WebRender only, or does it affect Firefox even when WebRender is disabled?

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Milan Sreckovic [:milan] from comment #7)
> Sotaro, is this WebRender only, or does it affect Firefox even when
> WebRender is disabled?

It is WebRender only.

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> I guess while you're doing this, can you also remove the "\n" from the rest
> of the MOZ_CRASHes in this file? Then we can dupe bug 1400070 to this one.

Ok, I'll update the patch.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove MOZ_CRASH in GLContextEGLFactory::Create

Comment 11

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42827b5ccfd7c039963b146f29813a862cbb25d9

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdecec06131e
Remove MOZ_CRASH in GLContextEGLFactory::Create r=jgilbert

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdecec06131e