Closed Bug 1366844 Opened 7 years ago Closed 7 years ago

Update sync iconography for Photon

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Version:
53 Branch
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Flags:
Tracking Status
firefox57 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

Bug 1366844 - replace old sync imagery in hamburger panel,
59 bytes, text/x-review-board-request
jaws
: review+
Gijs
: ui-review+
Details 
We should update the sync icons used in the main/hamburger panel for Photon. This includes the spinning animation for the 'currently syncing' icon.
Flags: qe-verify+
Whiteboard: [photon-visual] → [photon-structure]
Priority: -- → P2
QA Contact: gwimberly
Blocks: 1387512
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Priority: P2 → P1
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

Linux and Windows builds are available for testing on try, OSX should be there soon too:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8b5327dd9b6

Ryan, can you check this looks OK to you?
Attachment #8897086 - Flags: ui-review?(rfeeley)
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173650

::: browser/themes/linux/jar.mn
(Diff revision 1)
> -  skin/classic/browser/sync-horizontalbar.png
> -  skin/classic/browser/sync-horizontalbar@2x.png
>    skin/classic/browser/sync-mobileIcon.svg  (../shared/sync-mobileIcon.svg)
> -  skin/classic/browser/syncProgress-horizontalbar.png
> -  skin/classic/browser/syncProgress-horizontalbar@2x.png

Are these files actually removed from mozilla-central?

I don't see anything in https://hg.mozilla.org/try/rev/d6098d2ecaab that says the files have been deleted.
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173650

> Are these files actually removed from mozilla-central?
> 
> I don't see anything in https://hg.mozilla.org/try/rev/d6098d2ecaab that says the files have been deleted.

D'oh, good point. Fixed!
Looks great!
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

ui-r+ from comment 8! \o/
Attachment #8897086 - Flags: ui-review?(rfeeley) → ui-review+
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173680

Thanks!
Attachment #8897086 - Flags: review?(jaws) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c1948bdd4b73
replace old sync imagery in hamburger panel, r=jaws
Iteration: 57.1 - Aug 15 → 57.2 - Aug 29
https://hg.mozilla.org/mozilla-central/rev/c1948bdd4b73
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
QA Contact: gwimberly → Virtual
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: