Update sync iconography for Photon

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
a year ago
10 months ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

53 Branch
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We should update the sync icons used in the main/hamburger panel for Photon. This includes the spinning animation for the 'currently syncing' icon.
Flags: qe-verify+
(Assignee)

Updated

a year ago
Whiteboard: [photon-visual] → [photon-structure]
Priority: -- → P2
QA Contact: gwimberly
(Assignee)

Updated

a year ago
Duplicate of this bug: 1377220
(Assignee)

Updated

11 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Priority: P2 → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 3

11 months ago
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

Linux and Windows builds are available for testing on try, OSX should be there soon too:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8b5327dd9b6

Ryan, can you check this looks OK to you?
Attachment #8897086 - Flags: ui-review?(rfeeley)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173650

::: browser/themes/linux/jar.mn
(Diff revision 1)
> -  skin/classic/browser/sync-horizontalbar.png
> -  skin/classic/browser/sync-horizontalbar@2x.png
>    skin/classic/browser/sync-mobileIcon.svg  (../shared/sync-mobileIcon.svg)
> -  skin/classic/browser/syncProgress-horizontalbar.png
> -  skin/classic/browser/syncProgress-horizontalbar@2x.png

Are these files actually removed from mozilla-central?

I don't see anything in https://hg.mozilla.org/try/rev/d6098d2ecaab that says the files have been deleted.
(Assignee)

Comment 5

11 months ago
mozreview-review-reply
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173650

> Are these files actually removed from mozilla-central?
> 
> I don't see anything in https://hg.mozilla.org/try/rev/d6098d2ecaab that says the files have been deleted.

D'oh, good point. Fixed!
Comment hidden (mozreview-request)

Comment 8

11 months ago
Looks great!
(Assignee)

Comment 9

11 months ago
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

ui-r+ from comment 8! \o/
Attachment #8897086 - Flags: ui-review?(rfeeley) → ui-review+

Comment 10

11 months ago
mozreview-review
Comment on attachment 8897086 [details]
Bug 1366844 - replace old sync imagery in hamburger panel,

https://reviewboard.mozilla.org/r/168378/#review173680

Thanks!
Attachment #8897086 - Flags: review?(jaws) → review+

Comment 11

11 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c1948bdd4b73
replace old sync imagery in hamburger panel, r=jaws

Updated

11 months ago
Iteration: 57.1 - Aug 15 → 57.2 - Aug 29

Comment 12

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c1948bdd4b73
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
QA Contact: gwimberly → Virtual

Updated

11 months ago
Flags: qe-verify+
(Assignee)

Updated

10 months ago
Duplicate of this bug: 1377691
You need to log in before you can comment on or make changes to this bug.