Closed Bug 1366956 Opened 2 years ago Closed 2 years ago

stylo: Support layout.css.prefixes.device-pixel-ratio-webkit pref

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(3 files, 1 obsolete file)

We are not currently shipping -webkit-device-pixel-ratio because of some reason, but it seems to me we want to keep the implementation and its tests so that we can enable it at some point.
This probably could make use of the function I added to the first (now obsolete) patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1366914
I think we should use a static bool with observer as well. We can probably create a new class and move prefs we need there, then share them between Gecko and Stylo, so that Servo side can also access the value natively.
Priority: -- → P3
Assignee: nobody → xidorn+moz
Comment on attachment 8887291 [details]
Bug 1366956 part 1 - Move CSS prefs from nsCSSParser into an independent class.

https://reviewboard.mozilla.org/r/158090/#review163272

::: layout/style/StylePrefs.h:9
(Diff revision 1)
> +
> +namespace mozilla {
> +
> +struct StylePrefs

Nit: add a comment here saying what StylePrefs is for?
Attachment #8887291 - Flags: review?(cam) → review+
Comment on attachment 8887292 [details]
Bug 1366956 part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access.

https://reviewboard.mozilla.org/r/158092/#review163274
Attachment #8887292 - Flags: review?(cam) → review+
It looks like this, as well as bug 1381690 has issue with bindgen on win32...
Comment on attachment 8887294 [details]
Bug 1366956 part 3 - Update test expectations.

https://reviewboard.mozilla.org/r/158096/#review163306
Attachment #8887294 - Flags: review?(cam) → review+
Comment on attachment 8887293 [details]
Handle device-pixel-ratio-webkit pref correctly.

https://reviewboard.mozilla.org/r/158094/#review163310
Attachment #8887293 - Flags: review?(cam) → review+
Ok, so this is blocked on servo/rust-bindgen#822.
Blocks: 1338764
Depends on: 1385147
Servo side: servo/servo#17922
Attachment #8887293 - Attachment is obsolete: true
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ba584a59aa7
part 1 - Move CSS prefs from nsCSSParser into an independent class. r=heycam
https://hg.mozilla.org/integration/autoland/rev/01dd3ada68f2
part 2 - Replace IsFramesTimingEnabled FFI function with direct pref cache access. r=heycam
https://hg.mozilla.org/integration/autoland/rev/10878b3f929d
part 3 - Update test expectations. r=heycam
You need to log in before you can comment on or make changes to this bug.