1367069 - "New tab" in the search widget doesn't open a custom homepage even when "Also use for new tabs" is set

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Tom Klein]

From bug 1323437 comment 5:
1) Set a custom homepage, and set "Also use for new tabs" for the homepage.
2) Click on "new tab" from the search widget.

Expected results: a new tab is opened and the homepage is loaded.

Actual results: a new tab is opened and "about:home" is loaded.
(Exception 1: if you kill fennec and then click "new tab" in the search widget, the homepage is loaded regardless of the setting of "Also use for new tabs" - see also bug 1367063.)
(Exception 2: if "don't keep activities" is set then there is no new tab - bug 1366993.)

Comment 1

[friedger]

Attachment: Bug 1367069 - "New tab" in the search widget doesn't open a custom homepage even when "Also use for new tabs" is set

add check for external url in onNewIntent, use Tab.addTabs() for no url or about:home

Review commit: https://reviewboard.mozilla.org/r/147106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147106/

Comment 2

[Tom Klein]

Thanks for picking these up friedger - I'm not a reviewer, so Sebastian, could you suggest a reviewer/reviewers for this and bug 1366993 and bug 1367063?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

@Max: Can you review this patch? :)

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8875680 [details]
Bug 1367069 - "New tab" in the search widget doesn't open a custom homepage even when "Also use for new tabs" is set

https://reviewboard.mozilla.org/r/147106/#review152234

LGTM. Thanks a lot! :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16f21b8add66
"New tab" in the search widget doesn't open a custom homepage even when "Also use for new tabs" is set r=maliu

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16f21b8add66

Comment 7

[Sorina Florean [:sflorean]]

Verified as fixed in build 57.0a1 from 2017-09-21.
Devices: Honor 8 (Android 7.0), Huawei Honor (Android 5.1.1).

Comment 8

[Nevin Chen(Not active on Bugzilla)]

The code here breaks deep link about:home?panel=7f6d419a-cd6c-4e34-b26f-f68b1b551907 (firefox://bookmark_list), which is critical for marketing campaigns.

Hi Max
Should we back this out?

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Please help back this out in Nightly and Beta. See comment 8

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Please give me some advice on this... Thanks!

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Wes, Ryan, could you please help backout the fix here? As Nevin requested, it needs to be backed out from Nightly and Beta both. Thanks!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb26449905c0a24eb0f7294f78345b2dbb682ba6

Will backout from Beta momentarily.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

And from Beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/dabec7472928

I'm calling 57 affected because it's not clear to me if the intent is to eventually re-land a fixed patch there or not. Please set the status to wontfix if the answer is no.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout: https://hg.mozilla.org/mozilla-central/rev/fb26449905c0

Comment 15

[Nevin Chen(Not active on Bugzilla)]

Hi Ryan
After backing this out, a part of the issue is gone. There could be some improvement in the future but need to ride the train.
Mainly beacause we need more time to investigate and come out a better solution. We don't want to rush for a fix to uplift.(may cause more regression)
Thanks for the prompt support.

Comment 16

[Jan Henning [:JanH]]

This is an ex-Search Activity now (bug 1221344).