If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[geckoview] Figure out text selection actions

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
GeckoView
P1
normal
RESOLVED FIXED
4 months ago
3 days ago

People

(Reporter: snorp, Assigned: jchen)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments)

You can select text right now, but we don't show any type of menu or expose any interface to the application for handling that.
Summary: Figure out text selection actions → [geckoview] Figure out text selection actions
Component: Embedding: APIs → GeckoView
Product: Core → Firefox for Android
Version: unspecified → Trunk
Blocks: 1208655
No longer blocks: 1356346
Dylan has been looking at this. The plan is to just handle all of the text selection stuff internally for now. GeckoView will take care of popping up the clipboard action UI.
Assignee: nobody → droeh
Priority: -- → P1
Sorina, can you please test this and see if it is reproducible on different devices?
Flags: needinfo?(sorina.florean)
wrong bug...
Flags: needinfo?(sorina.florean)
(Assignee)

Updated

7 days ago
Assignee: droeh → nchen
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 9

6 days ago
mozreview-review
Comment on attachment 8907672 [details]
Bug 1367079 - 1. Update TextSelection implementations for GeckoView;

https://reviewboard.mozilla.org/r/179334/#review184556
Attachment #8907672 - Flags: review?(snorp) → review+
(Reporter)

Comment 10

6 days ago
mozreview-review
Comment on attachment 8907673 [details]
Bug 1367079 - 2. Move Share:Text listener to GeckoApplication;

https://reviewboard.mozilla.org/r/179336/#review184558
Attachment #8907673 - Flags: review?(snorp) → review+
(Reporter)

Comment 11

6 days ago
mozreview-review
Comment on attachment 8907674 [details]
Bug 1367079 - 3. Add utility for registering lazy WindowEventDispatcher listener;

https://reviewboard.mozilla.org/r/179338/#review184560
Attachment #8907674 - Flags: review?(snorp) → review+
(Reporter)

Comment 12

6 days ago
mozreview-review
Comment on attachment 8907675 [details]
Bug 1367079 - 4. Move ActionBarHandler usage out of browser.js;

https://reviewboard.mozilla.org/r/179340/#review184564
Attachment #8907675 - Flags: review?(snorp) → review+
(Reporter)

Comment 13

6 days ago
mozreview-review
Comment on attachment 8907676 [details]
Bug 1367079 - 5. Add TextSelection support in custom tabs and PWA;

https://reviewboard.mozilla.org/r/179342/#review184566
Attachment #8907676 - Flags: review?(snorp) → review+

Comment 14

5 days ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58e575edf398
1. Update TextSelection implementations for GeckoView; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/1af8aae9f137
2. Move Share:Text listener to GeckoApplication; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f1d3a461631
3. Add utility for registering lazy WindowEventDispatcher listener; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/c185dd417782
4. Move ActionBarHandler usage out of browser.js; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dae173f8fe8
5. Add TextSelection support in custom tabs and PWA; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/69521f759e29
6. Fix testAccessibleCarets; r=me
https://hg.mozilla.org/mozilla-central/rev/58e575edf398
https://hg.mozilla.org/mozilla-central/rev/1af8aae9f137
https://hg.mozilla.org/mozilla-central/rev/7f1d3a461631
https://hg.mozilla.org/mozilla-central/rev/c185dd417782
https://hg.mozilla.org/mozilla-central/rev/5dae173f8fe8
https://hg.mozilla.org/mozilla-central/rev/69521f759e29
Status: ASSIGNED → RESOLVED
Last Resolved: 4 days ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 22

4 days ago
Comment on attachment 8907672 [details]
Bug 1367079 - 1. Update TextSelection implementations for GeckoView;

Beta request for all patches.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Custom tabs feature slated for 57 would not have the text selection toolbar feature.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1367077, bug 1398409
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Well-tested locally and the patches only just missed the Beta merge by a few hours.
[String changes made/needed]: None
Attachment #8907672 - Flags: approval-mozilla-beta?
Comment on attachment 8907672 [details]
Bug 1367079 - 1. Update TextSelection implementations for GeckoView;

This shouldn't need an uplift request to get into 57, since we are going to sync m-c to m-b again.
Attachment #8907672 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.