Closed
Bug 1367911
Opened 7 years ago
Closed 7 years ago
Hook up SendSetConfirmedTargetAPZC for webrender
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
Right now there is a codepath where APZ code on the main-thread needs to wait for layerization to happen, and then sends a message over to APZ on the compositor. It currently does this using the SendSetConfirmedTargetAPZC message on PLayerTransaction at [1]. However, the code assumes there is a PLayerTransaction - which is not the case with WebRender. Instead it should allow sending the message over PWebRenderBridge as well. [1] http://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/gfx/layers/apz/util/APZCCallbackHelper.cpp#711
|
Assignee | |
Comment 1•7 years ago
|
||
The patches here will build on top of the patches in bug 1367837. Try push is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=2feca75a7c250748abe67910fe1a33793925654f
Depends on: 1367837
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8871735 [details] Bug 1367911 - Refactor the SetConfirmedTargetAPZC function to take a layers id. https://reviewboard.mozilla.org/r/143216/#review147156
Attachment #8871735 -
Flags: review?(dvander) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8871736 [details] Bug 1367911 - Update APZCCallbackHelper to support WebRender. https://reviewboard.mozilla.org/r/143218/#review147158 I obviously don't know the WR side of this but in terms of changes to the APZ code it looks fine.
Attachment #8871736 -
Flags: review?(dvander) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8871737 [details] Bug 1367911 - Extract a GetLayersId() helper. https://reviewboard.mozilla.org/r/143220/#review147160
Attachment #8871737 -
Flags: review?(dvander) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/1d0c58e01f4d Refactor the SetConfirmedTargetAPZC function to take a layers id. r=dvander https://hg.mozilla.org/projects/graphics/rev/a7a313dc31ab Update APZCCallbackHelper to support WebRender. r=dvander https://hg.mozilla.org/projects/graphics/rev/577082fce7bf Extract a GetLayersId() helper. r=dvander
|
|
Assignee | |
Comment 9•7 years ago
|
||
I made an error in part 1, resulting in some test failures. CrossProcessCompositorBridge::SetConfirmedTargetAPZC passes |aLayersId| to CompositorBridgeParent, so the assertion I added to the top of CompositorBridgeParent::SetConfirmedTargetAPZC is incorrect. I'll remove the assertion. The other alternatives are (a) having CrossProcessCompositorBridge pass the root compositor's layers id or (b) having the assertion allow layers ids where `sIndirectLayerTrees[aLayersId]->mParent == this`. I think the first option is probably a little misleading if we ever decide to use the aLayersId in the APZ code (right now it's unused) and the second option is probably not worth the effort.
|
||
Comment 10•7 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/4e09f53bcb57 Follow-up to remove invalid assertion. r=me
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d0c58e01f4d https://hg.mozilla.org/mozilla-central/rev/a7a313dc31ab https://hg.mozilla.org/mozilla-central/rev/577082fce7bf https://hg.mozilla.org/mozilla-central/rev/4e09f53bcb57
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•