Closed Bug 1369982 Opened 4 years ago Closed 4 years ago
TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test
_crash _service .js | xpcshell return code: 0
This test extracts information from a dummy crash file. The annotation that is missing and is causing the test to fail is extracted here: https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashService.js#162 If we don't reach that part of the code it means that the previous line in which we run the minidump-analyzer tool failed. The minidump-analyzer normally lives in the dist/bin directory when running tests and it's located by looking for it in the "GreBinD" directory obtained by the directory service, see here: https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashService.js#31 If this is failing only on Linux and Windows but not on Mac then chances are that the code cannot find the minidump-analyzer executable on those two platforms but finds it successfully on Mac. I don't have a comm-central build handy to check what's happening but I'll be glad to help on fixing this.
Bug 1317968 adds it to the distribution. Does this need porting?
(In reply to Frank-Rainer Grahl (:frg) from comment #2) > Bug 1317968 adds it to the distribution. Does this need porting? If you want to get stack traces in crash pings from release versions then yes. If not then I can amend the crash service code (and tests) to ignore failures if the minidump-analyzer is not present.
Tested with suite. Seems to be build but not distributed for OSX.
Attachment #8874473 - Flags: review?(jorgk)
Ahh I see. It is in BINPATH@/crashreporter.app/ So that is why OSX does not fail. I think I can safely take the bug now :)
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Comment on attachment 8874473 [details] [diff] [review] 1369982-minidumpanalyzer.patch Thanks, let me land this with bug 1370302. (Sorry out for Pfingsten.)
Attachment #8874473 - Flags: review?(jorgk) → review+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.