1369982 - TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | test_addCrash - [test_addCrash : 59] "undefined" == "content"

First seen on Daily run on Thu Jun 1, 2017, 16:59:46

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=57b7bce56f6b5a431672b257798eef387ef836aa&selectedJob=104032866

M-C: last good: 0bcea6bac1797e14b00af45cc7c368d124
M-C: first bad: aeb3d0ca558f034cbef1c5a68bd07dd738

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0bcea6bac1797e14b00af45cc7c368d124&tochange=aeb3d0ca558f034cbef1c5a68bd07dd738

https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32-debug/1496431044/comm-central_win7_ix-debug_test-xpcshell-bm126-tests1-windows-build4.txt.gz

says:

14:09:44  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | test_addCrash - [test_addCrash : 59] "undefined" == "content"
14:09:44     INFO -  C:/slave/test/build/tests/xpcshell/tests/toolkit/components/crashes/tests/xpcshell/test_crash_service.js:test_addCrash:59
14:09:44     INFO -  exiting test
14:09:44     INFO -  Unexpected exception 2147500036
14:09:44     INFO -  undefined
14:09:44     INFO -  exiting test
14:09:44     INFO -  PID 6544 | JavaScript error: resource://gre/modules/XPCOMUtils.jsm, line 230: uncaught exception: 2147500037
14:09:44     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "uncaught exception: 2147500037" {file: "resource://gre/modules/XPCOMUtils.jsm" line: 230}]"
14:09:44     INFO -  PID 6544 | Unable to read VR Path Registry from C:\\Users\\cltbld.T-W732-IX-061.002\\AppData\\Local\\openvr\\openvrpaths.vrpath

2147500037 = 0x80004005 = NS_ERROR_FAILURE

This comes from bug 1359326:
https://hg.mozilla.org/mozilla-central/rev/001d49708a35#l20.33
since test_addCrash is now failing.

Gabriele and Benjamin: Any hints why this test is now failing in the Thunderbird Xpcshell suite which is running the Mozilla core tests?

Apparently this line is failing:
59  Assert.equal(crash.metadata.ProcessType, "content");

An interesting aspect is that the test is only failing on Linux and Windows, not failing on Mac.

Comment 1

[Gabriele Svelto [:gsvelto]]

This test extracts information from a dummy crash file. The annotation that is missing and is causing the test to fail is extracted here:

https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashService.js#162

If we don't reach that part of the code it means that the previous line in which we run the minidump-analyzer tool failed. The minidump-analyzer normally lives in the dist/bin directory when running tests and it's located by looking for it in the "GreBinD" directory obtained by the directory service, see here:

https://dxr.mozilla.org/mozilla-central/rev/8a3aa1701537ea6b8334f432cd030d260d492fa3/toolkit/components/crashes/CrashService.js#31

If this is failing only on Linux and Windows but not on Mac then chances are that the code cannot find the minidump-analyzer executable on those two platforms but finds it successfully on Mac. I don't have a comm-central build handy to check what's happening but I'll be glad to help on fixing this.

Comment 2

[Frank-Rainer Grahl (:frg)]

Bug 1317968 adds it to the distribution. Does this need porting?

Comment 3

[Gabriele Svelto [:gsvelto]]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)
> Bug 1317968 adds it to the distribution. Does this need porting?

If you want to get stack traces in crash pings from release versions then yes. If not then I can amend the crash service code (and tests) to ignore failures if the minidump-analyzer is not present.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1369982-minidumpanalyzer.patch

Tested with suite. Seems to be build but not distributed for OSX.

Comment 5

[Frank-Rainer Grahl (:frg)]

Ahh I see. It is in BINPATH@/crashreporter.app/

So that is why OSX does not fail. I think I can safely take the bug now :)

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8874473 [details] [diff] [review]
1369982-minidumpanalyzer.patch

Thanks, let me land this with bug 1370302. (Sorry out for Pfingsten.)

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/ebb81a299d0a928510a84dba545491d28ee1f7c8