Open Bug 1370314 Opened 3 years ago Updated 2 years ago
Monkey 2017 installer rollup .
While working on bug 1369982 and bug 1370302 I compared the SeaMonkey installer files to the ones in browser. I only checked the toolkit differences and noticed that we might want to port some installer bugs.
Take one and get 2 free: Bug 1113086 Bug 1123237 Bug 1129040 Bug 1148307 Bug 1156135 Bug 1164014 Bug 1188158 Bug 1214462 Bug 1233803 Bug 1233803 Bug 1245571 Bug 1255700 Bug 1294772 Bug 1317968 Bug 1319159 Bug 1333003 Bug 1345361 Bug 394984 Most are e10s or web extensions. I would take all but marionette and telemetry. Bug 1317968, Bug 1285063 and Bug 1368102 are already in review by jorgk. Needed for both us and TB right now. The OSX launch service bug needs more work but I can try to do it with my Mac Mini. What about pdfjs in a separate bug? With NPAPI going away pdf support is limited right now. It might be an easy fix.
Comment on attachment 8874522 [details] [diff] [review] 1370314-installer-wip.patch Hmm, I haven't digged into this, but you probably miss something here. 'mach package' gives me this: cp -RL ../../dist/branding/icons/*.icns ../../dist/SeaMonkey.app/Contents/Resources/ mkdir -p /Contents/Library/LaunchServices mkdir: /Contents/Library/LaunchServices: Permission denied
Attachment #8874522 - Flags: feedback?(stefanh) → feedback-
Comment on attachment 8874522 [details] [diff] [review] 1370314-installer-wip.patch >+ $(MKDIR) -p $(dist_dest)/Contents/Library/LaunchServices >+ mv -f $(dist_dest)/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater $(dist_dest)/Contents/Library/LaunchServices >+ ln -s ../../../../Library/LaunchServices/org.mozilla.updater $(dist_dest)/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater Ah, now I see - we don't know anything of dist_dest :-)
Replace '$(dist_dest)' with '$(DIST)/$(MOZ_MACBUNDLE_NAME)' and it works.
Stefan, Sorry wasn't clear. I didn't build osx with the patch. This is the only bug which probably would also need some changes in suite so I would likely spin it off. At this point I would just like to know which of the bugs we should port.
Update. Also tested on OSX but the launch service will, for sure, not work without additional changes so I wouldn't include it or spin it off. Just pick the bugs which should be ported.
Attachment #8874522 - Attachment is obsolete: true
Attachment #8874522 - Flags: feedback?(rsx11m.pub)
Attachment #8874522 - Flags: feedback?(iann_bugzilla)
Attachment #8878866 - Flags: feedback?(iann_bugzilla)
I have another list of (Windows-)installer bugs that are in need to be ported: Bug 1249979 (port of bug 1229626) Bug 1067089 (ports of bug 544672 and bug 621873) Bug 1101237 This are mostly bugs regarding the pinning of the SeaMonkey shortcut on Win7+, as this does completely not work in SeaMonkey currently (neither is SeaMonkey being pinned to the taskbar nor stays it there if pinned manually and launched (a second icon is then created for the launched application instead of using the pinned one). And the old quick launch options do not work on Win7+ at all. Not sure, though, if there already are bugs for this...
>> (neither is SeaMonkey being pinned to the taskbar nor stays it there if pinned manually Hmm just tried manual pinning in 8.1 and this works for me in 2.49.1. Ported in bug 1249972 (bug 1249979 / bug 1229626) I need to look at the other 2.
As some of this has been covered in another bug, will this become a meta bug?
> will this become a meta bug? Yes I think that makes sense.
Comment on attachment 8878866 [details] [diff] [review] 1370314-installer-wip2.patch Clearing the request since I think it's obsolete now.
The patch is obsolete but I would still like input what we should take. See user story.
User Story: (updated)
Depends on: 1369982
User Story: (updated)
Summary: SeaMonkey 06/2017 installer rollup. → SeaMonkey 2017 installer rollup.
Comment on attachment 8878866 [details] [diff] [review] 1370314-installer-wip2.patch >+++ b/suite/app/Makefile.in >+# https://bugzilla.mozilla.org/show_bug.cgi?id=394984 >+ $(MKDIR) -p $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/Library/LaunchServices >+ mv -f $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/Library/LaunchServices >+ ln -s ../../../../Library/LaunchServices/org.mozilla.updater $(DIST)/$(MOZ_MACBUNDLE_NAME)/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater This needs updating to reflect Bug 1278042 and Bug 1407285 >+++ b/suite/installer/package-manifest.in >@@ -131,16 +138,21 @@ > #ifdef MOZ_GTK3 > @BINPATH@/@DLL_PREFIX@mozgtk@DLL_SUFFIX@ > @BINPATH@/gtk2/@DLL_PREFIX@mozgtk@DLL_SUFFIX@ > #endif This bit has bit rotted (from port of Bug 1409707), though does this block need moving to https://dxr.mozilla.org/comm-central/source/suite/installer/package-manifest.in#117) to match Firefox? >@@ -192,16 +204,18 @@ >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1345361 >+@RESPATH@/components/dom_payments.xpt >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1123237 >+#ifdef MOZ_GECKO_PROFILER >+@RESPATH@/components/memory_profiler.xpt >+#endif >+@RESPATH@/components/urlformatter.xpt xpt files were removed in Bug 1451075 so changes no longer needed >+; Safe Browsing >+@RESPATH@/components/nsURLClassifier.manifest >+@RESPATH@/components/nsUrlClassifierHashCompleter.js >+@RESPATH@/components/nsUrlClassifierListManager.js >+@RESPATH@/components/nsUrlClassifierLib.js >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1188158 > @RESPATH@/components/url-classifier.xpt >-@RESPATH@/components/urlformatter.xpt xpt file already removed in Bug 1451075 so change no longer needed >+; Private Browsing >+@RESPATH@/components/privatebrowsing.xpt >+@RESPATH@/components/PrivateBrowsing.manifest >+@RESPATH@/components/PrivateBrowsingTrackingProtectionWhitelist.js Bitrotted by Bug 1451075 so xpt file change no longer needed > @RESPATH@/components/nsBlocklistService.js >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1129040 >+@RESPATH@/components/nsBlocklistServiceContent.js This was removed again for Gecko 61 in Bug 1443870 - remove content-process blocklist service (and ported in Bug 1446613) >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1255700 >+@RESPATH@/components/FxAccountsComponents.manifest >+@RESPATH@/components/FxAccountsPush.js > @RESPATH@/components/Weave.js Are these additions still needed with Weave.js removed (Bug 1432273 - Disable sync and its ui in SeaMonkey until sync 1.5 is ported) >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1113086 >+@RESPATH@/components/dom_audiochannel.xpt xpt file already removed in Bug 1451075 so change no longer needed > ; Address Sanitizer >-#if defined(CLANG_CXX) >-#if defined(MOZ_ASAN) || defined(MOZ_TSAN) >-@BINPATH@/llvm-symbolizer >+; https://bugzilla.mozilla.org/show_bug.cgi?id=1333003 >+#ifdef LLVM_SYMBOLIZER >+@BINPATH@/@LLVM_SYMBOLIZER@ > #endif >+ >+#ifdef MOZ_CLANG_RT_ASAN_LIB >+@BINPATH@/@MOZ_CLANG_RT_ASAN_LIB@ > #endif This probably also needs Bug 1457523: Add msdia140.dll to the package on Windows ASan CI builds f=me for the moment
Attachment #8878866 - Flags: feedback?(iann_bugzilla) → feedback+
Comment on attachment 8878866 [details] [diff] [review] 1370314-installer-wip2.patch Clearing old NIs
You need to log in before you can comment on or make changes to this bug.