Closed Bug 137007 Opened 18 years ago Closed 12 years ago

add "Send Link" to link context menus

Categories

(SeaMonkey :: UI Design, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: wladow)

References

()

Details

Attachments

(2 files, 1 obsolete file)

(filing rfe's for proposed/unimplemented browser context menus, based on
Marlon's spec.)

add "Open Link" to the link as text link and image as link context menus.
add "Send Link" to the same menus (might as well combine here since they both
appear in them in the spec).
QA Contact: paw → sairuh
Summary: add "Open Link" to link context menus → add "Open Link" and "Send Link" to link context menus
The Send Link entry was removed when Mozilla's menus were cleaned up.
Please re-add it ASAP. It was very useful.
Target Milestone: --- → Future
Open Link is bug 64749, Send Link is bug 139835.

*** This bug has been marked as a duplicate of 64749 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
reopening. i filed this after discussion with marlon. we know that Send Link was
removed for the current context menu implementation, but the latest version of
his spec asks to bring it back.

thanks for finding bug 64749, however --will add that to the dependency list of
bug 135841 as well.
Blocks: 135841
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Summary: add "Open Link" and "Send Link" to link context menus → add "Send Link" to link context menus
*** Bug 139835 has been marked as a duplicate of this bug. ***
*** Bug 165627 has been marked as a duplicate of this bug. ***
I think this is useful and needed functionality.  Being able to right-click on a
link and send it is something that is handy.
Firebird has this now (bug 173954).
Reassigning obsolete bugs to their respective Seamonkey owners (i.e. nobody). 
If you want this fixed for Firefox, change the Product and Component accordingly
and reassign back to me.
Assignee: firefox → guifeatures
Status: REOPENED → NEW
Target Milestone: Future → ---
Product: Core → Mozilla Application Suite
bump
QA Contact: bugzilla
Filter "spam" on "guifeatures-nobody-20080610".
Assignee: guifeatures → nobody
QA Contact: guifeatures
Duplicate of this bug: 416613
Attached patch v1Splinter Review
This patch adds "Send Link" to context menu for saveable links. It means this menu item is shown for several protocols, f.e. mailto: links too. I don't know if mailto: as saveable link is desired but that's not what this bug is about. Maybe follow-up?

Patch uses existing (and updated) sendLink function that is used for File -> Send Link menu item. I'm using a new string for context menu, but with the same wording. Maybe we should reword File -> Send Link to something like "Send link to this page"? Because that's what it is doing.
Assignee: nobody → wladow
Status: NEW → ASSIGNED
Attachment #327784 - Flags: superreview?(neil)
Attachment #327784 - Flags: review?(neil)
Comment on attachment 327784 [details] [diff] [review]
v1

>+        // Save/send link depends on whether we're in a link.
>+        if (this.onSaveableLink) {
>           goSetMenuValue( "context-savelink", this.autoDownload ? "valueSave" : "valueSaveAs" );
>         this.showItem( "context-savelink", this.onSaveableLink );
>+        this.showItem( "context-sendlink", this.onSaveableLink );
>+        }
This is wrong; the if is only there to avoid upating the "Save Link Target (As)..." label if we're not going to show the menuitem.

> <!ENTITY contextSendPage.label           "Send Page…">
> <!ENTITY contextSendPage.accesskey       "d">
>+<!ENTITY contextSendLink.label           "Send Link…">
>+<!ENTITY contextSendLink.accesskey       "d">
Hmm, I think we need to work out why Send Page doesn't get hidden on links...
Comment on attachment 327784 [details] [diff] [review]
v1

> <!ENTITY contextSendPage.label           "Send Page…">
> <!ENTITY contextSendPage.accesskey       "d">
>+<!ENTITY contextSendLink.label           "Send Link…">
>+<!ENTITY contextSendLink.accesskey       "d">
> <!ENTITY contextSendImage.label          "Send Image…">
> <!ENTITY contextSendImage.accesskey      "n">
OK, so Send Page is currently only hidden for a linked image, but this isn't good enough if we want to be able to send link. I also think that the text should be "Send Link Target..." (sorry I'm too lazy to copy and paste a unicode ellipsis)
Attachment #327784 - Flags: superreview?(neil)
Attachment #327784 - Flags: review?(neil)
Attachment #327784 - Flags: review-
(In reply to comment #15)
> (From update of attachment 327784 [details] [diff] [review])
> > <!ENTITY contextSendPage.label           "Send Page…">
> > <!ENTITY contextSendPage.accesskey       "d">
> >+<!ENTITY contextSendLink.label           "Send Link…">
> >+<!ENTITY contextSendLink.accesskey       "d">
> > <!ENTITY contextSendImage.label          "Send Image…">
> > <!ENTITY contextSendImage.accesskey      "n">
> OK, so Send Page is currently only hidden for a linked image, but this isn't
> good enough if we want to be able to send link. I also think that the text
> should be "Send Link Target..." (sorry I'm too lazy to copy and paste a unicode
> ellipsis)
> 
Why do you want to have text "Send Link Target"? Link target means something that you see after clicking on a link. So if this link target is a .zip, "send link target" should send that file etc. We are sending just a link to that file.

Attached patch v2 (obsolete) — Splinter Review
Description:
1) use updated SendLink function
2) show Send Link for saveable links
3) hide Send Page in links context menus
4) use "Send This Link" string in context menus
Attachment #328850 - Flags: superreview?(neil)
Attachment #328850 - Flags: review?(neil)
(In reply to comment #17)
> 3) hide Send Page in links context menus
The alternative I guess would be to rename it to "Send This Page",
but I'm not sure we have a spare accesskey we can use for it!
Attached patch v3Splinter Review
OK, let's rename Send Page, "k" is available as accesskey for Send This Link.
Attachment #328850 - Attachment is obsolete: true
Attachment #328862 - Flags: superreview?(neil)
Attachment #328862 - Flags: review?(neil)
Attachment #328850 - Flags: superreview?(neil)
Attachment #328850 - Flags: review?(neil)
Comment on attachment 328862 [details] [diff] [review]
v3

>-        if (this.onSaveableLink)
>+        if (this.onSaveableLink) 
This file has far too many trailing spaces as it is ;-)
Attachment #328862 - Flags: superreview?(neil)
Attachment #328862 - Flags: superreview+
Attachment #328862 - Flags: review?(neil)
Attachment #328862 - Flags: review+
Fix checked in without that one space.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago12 years ago
Resolution: --- → FIXED
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.