DirectoryLinksProvider is started too early during startup

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
a year ago
7 months ago

People

(Reporter: florian, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
DirectoryLinksProvider.init() is currently called from _finalUIStartup in nsBrowserGlue.js. This is before the first window browser is created and before command line handlers have been invoked.

When it's the first startup (ie. we are creating the profile), initializing DirectoryLinksProvider makes it download a JSON file, which forces initialization of NSS on the main thread. See this profile where this takes 451ms before first paint on the quantum reference hardware: https://perfht.ml/2qX4KZo
(Assignee)

Comment 1

7 months ago
:Mardak, does AS still use this? I think it's only the "old" about:newtab that uses it, right? I don't see any consumers under the AS add-on directory (or anywhere else, really).

So maybe we can just get rid of it altogether? Is there a bug on file about removing the old about:newtab now that the prefs are gone? I didn't see it in the deps of bug 1433324...

Given the perf focus, I expect I might just rip this out independently from anything else, if possible. Does that sound OK?
Assignee: nobody → gijskruitbosch+bugs
Flags: needinfo?(edilee)
Priority: -- → P2
I believe it's unused, although it's not as simple as doing a search for DirectoryLinksProvider. In particular NewTabUtils.links.addProvider(DirectoryLinksProvider); modifies the behavior of NewTabUtils via what links it returns and related events. I did end up removing one caller of NewTabUtils.links.getLinks in bug 1433324 https://hg.mozilla.org/mozilla-central/rev/088e727e5cf7#l2.102

I also removed quite a bit of the DirectoryLinksProvider code in bug 1241390.

It looks like a web extension can specifically request a provider's link, but I don't think it could have specifically requested DirectoryLinksProvider anyway? darktrojan, https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ext-topSites.js#20-24 ?

ursula, any additional thoughts?
Blocks: 1433133
Depends on: 1241390, 1433324
Flags: needinfo?(usarracini)
Flags: needinfo?(geoff)
Flags: needinfo?(edilee)
(Assignee)

Comment 3

7 months ago
(In reply to Ed Lee :Mardak from comment #2)
> It looks like a web extension can specifically request a provider's link,
> but I don't think it could have specifically requested
> DirectoryLinksProvider anyway? darktrojan,
> https://searchfox.org/mozilla-central/source/toolkit/components/extensions/
> ext-topSites.js#20-24 ?

ISTM that code should ideally be switched to rely on AS's top sites anyway, probably fetching them the same way the Library menu code does?
I can't think of any reason not to just delete the DirectoryLinksProvider code altogether at this point.
Flags: needinfo?(usarracini)
I don't think it's possible to access the DirectoryLinksProvider from a web extension.
Flags: needinfo?(geoff)
(Assignee)

Updated

7 months ago
Priority: P2 → --
Whiteboard: [fxperf] → [fxperf:p2]
(Assignee)

Comment 6

7 months ago
Useless (non-mainthread, thankfully) IO and jsm load on startup, plus what seems like a trivial patch, let's just make this P1 and get it over with... :-)
Whiteboard: [fxperf:p2] → [fxperf:p1]
Comment hidden (mozreview-request)

Comment 8

7 months ago
mozreview-review
Comment on attachment 8955196 [details]
Bug 1370930 - remove DirectoryLinksProvider,

https://reviewboard.mozilla.org/r/224362/#review230362

Could clean up a little bit more although it the additional stuff is probably only really affecting tests. So if you want to just note that in bug 1433133 to properly clean up prefs, that's fine too.

::: browser/base/content/test/newtab/head.js:5
(Diff revision 1)
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
>  const PREF_NEWTAB_ENABLED = "browser.newtabpage.enabled";
>  const PREF_NEWTAB_DIRECTORYSOURCE = "browser.newtabpage.directory.source";

Could additionally clean up things related to "browser.newtabpage.directory.source", e.g., defaults (firefox.js) / overrides (in this file, testing / reftest / talos)
Attachment #8955196 - Flags: review?(edilee) → review+
(Assignee)

Comment 9

7 months ago
mozreview-review
Comment on attachment 8955196 [details]
Bug 1370930 - remove DirectoryLinksProvider,

https://reviewboard.mozilla.org/r/224362/#review230380

::: browser/components/nsBrowserGlue.js:1820
(Diff revision 1)
>      }
>    },
>  
>    // eslint-disable-next-line complexity
>    _migrateUI: function BG__migrateUI() {
> -    const UI_VERSION = 62;
> +    const UI_VERSION = 63;

Self-nit: bump to bug 1370930 because of impending release changes that will bump to 63.
Comment hidden (mozreview-request)

Comment 11

7 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87d555dea4f4
remove DirectoryLinksProvider, r=Mardak
(Assignee)

Comment 12

7 months ago
(In reply to Ed Lee :Mardak from comment #8)
> Could clean up a little bit more although it the additional stuff is
> probably only really affecting tests. 

Tests that are disabled, right, because the pref is gone? :-)

> So if you want to just note that in
> bug 1433133 to properly clean up prefs, that's fine too.


I removed it in here. Is bug 1433133 just basically remove the newtab directory and all the pieces that hook up to it? Do we want to land that for 60 or are we deliberately waiting? My understanding is that, with the AS pref gone, it's impossible to switch back so I assume it's just dead code at this point. I might volunteer to remove it if nobody else is doing it soon...
Flags: needinfo?(edilee)
Yup bug 1433133 is for removing newtab (browser/base/content/newtab related stuff) whereas bug 1409054 is for browser/base/content/abouthome. Both should just be dead code and could be removed in 60 but been busy with feature work.
Flags: needinfo?(edilee)

Comment 14

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87d555dea4f4
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.