Closed Bug 137106 Opened 22 years ago Closed 22 years ago

need to move changes to nsPlatformToDOMKeyCode into gtk2

Categories

(Core :: XUL, defect)

Sun
Solaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: blizzard, Assigned: jay.yan)

References

Details

Attachments

(1 file)

There have been some recent changes to nsPlatformToDOMKeyCode related to crazy
sun keyboard symbols that need to be ported over.
Blocks: gtk2
It is me who made the crazy modifications, so I will port them to gtk2.
Status: NEW → ASSIGNED
assign to me
Assignee: blizzard → jay.yan
Status: ASSIGNED → NEW
I will make a all-in-1 patch to port the logic from widget/src/gtk here soon, it
includes the patches of:
bug 57262  Stop key
bug 43433  Meta key
bug 57263  Undo key
bug 61355  CapsLock key
bug 72054  F10 key

Status: NEW → ASSIGNED
OS: Linux → Solaris
QA Contact: jrgm → jessie.li
Hardware: PC → Sun
Support for F10 and Undo key has already been in the crossplatform part of trunk
now, so the bug will only cover Stop, Meta and capslock, that is to port the
patches of bug 57262, bug 43433 and bug 72054
sorry, should be bug 57262, bug 43433 and bug 61355

Attached patch patchSplinter Review
I tested it on my Solaris machine, and all the code is porting from gtk1. 
Akk, can you r=? thanks.
Comment on attachment 87502 [details] [diff] [review]
patch

sr=blizzard
Attachment #87502 - Flags: superreview+
Comment on attachment 87502 [details] [diff] [review]
patch

r=akkana
Attachment #87502 - Flags: review+
checked in,
thanks, Chris and Akk. 
Jay
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: