1371245 - test_crash_service.js fails on Mac artifact builds (test_addCrash - "undefined" == "content")

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

I've been seeing this failure doing artifact builds on try server and locally:

https://treeherder.mozilla.org/logviewer.html#?job_id=105445715&repo=try&lineNumber=7984

03:24:25     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "[Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIProcess.init]"  nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"  location: "JS frame :: jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/omni.ja!/components/CrashService.js :: runMinidumpAnalyzer/< :: line 44"  data: no]"]
03:24:25     INFO -  runMinidumpAnalyzer/<@jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/omni.ja!/components/CrashService.js:44:5
03:24:25     INFO -  Promise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:390:5
03:24:25     INFO -  runMinidumpAnalyzer@jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/omni.ja!/components/CrashService.js:27:10
03:24:25     INFO -  addCrash/blocker<@jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/omni.ja!/components/CrashService.js:161:15
03:24:25     INFO -  async*addCrash@jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/omni.ja!/components/CrashService.js:151:26
03:24:25     INFO -  test_addCrash@/builds/slave/test/build/tests/xpcshell/tests/toolkit/components/crashes/tests/xpcshell/test_crash_service.js:54:9
03:24:25     INFO -  async*asyncFunction@resource://gre/modules/Task.jsm:243:18
03:24:25     INFO -  Task_spawn@resource://gre/modules/Task.jsm:168:12
03:24:25     INFO -  _run_next_test@/builds/slave/test/build/tests/xpcshell/head.js:1548:9
03:24:25     INFO -  run@/builds/slave/test/build/tests/xpcshell/head.js:710:9
03:24:25     INFO -  _do_main@/builds/slave/test/build/tests/xpcshell/head.js:222:5
03:24:25     INFO -  _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:550:5
03:24:25     INFO -  @-e:1:1
03:24:25     INFO -  "
03:24:25     INFO -  TEST-PASS | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | test_addCrash - [test_addCrash : 58] Crash 56cd87bc-bb26-339b-3a8e-f00c0f11380e has been stored successfully. - {"_o":{"id":"56cd87bc-bb26-339b-3a8e-f00c0f11380e","remoteID":null,"type":"content-crash","crashDate":"2017-06-08T10:24:25.094Z" == true
03:24:25  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/crashes/tests/xpcshell/test_crash_service.js | test_addCrash - [test_addCrash : 59] "undefined" == "content"

Based on a related Thunderbird issue (bug 1369982), I'm guessing this is a regression from bug 1359326.

Comment 1

[Mark Banner (:standard8)]

Note: I flagged this as intermittent so that treeherder would pick it up and hopefully people will see it and know it is an issue.

Comment 2

[(not currently active) Ted Mielczarek]

My best guess here would be "artifact builds aren't downloading the minidump-analyzer binary".

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1371245 - Install minidump-analyzer to its final location in artifact builds.

The MacOS client artifact code relies on its own bookkeeping to install
binaries to their final locations and assumes that files installed to
'Contents/MacOS' will generally be installed to dist/bin by the build system.
This commit extends this logic to account for minidump-analyzer, which is
installed to directly to crashreporter.app/Contents/MacOS by setting DIST_SUBDIR
in moz.build.

Ideally we would rely on build system metadata to install binaries in artifact
builds, however this is non-trivial as the relevant moz.build data isn't
read in non-compile-environment builds and originating builds do not expose it
directly.

Review commit: https://reviewboard.mozilla.org/r/147676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147676/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8876220 [details]
Bug 1371245 - Install minidump-analyzer to its final location in artifact builds.

https://reviewboard.mozilla.org/r/147676/#review151954

lgtm.  Funny that there's so much variety in all of these sub-executables: some in the root, some in their own path, some in `Contents/MacOS`.  Best not to ask why :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84141f9b5d9a
Install minidump-analyzer to its final location in artifact builds. r=nalexander

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84141f9b5d9a