1371911 - JS errors when AppMenu is not on toolbar

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

I get JS errors when the Appmenu isn't in the toolbar when I open the view menu or I change to offline mode.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noAppMenuErrors.patch

Check first if the item exists.

Comment 2

[:aceman]

Comment on attachment 8876380 [details] [diff] [review]
noAppMenuErrors.patch

Review of attachment 8876380 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mail-offline.js
@@ +203,5 @@
>     */
>    updateOfflineUI: function(aIsOffline)
>    {
>      document.getElementById('goOfflineMenuItem').setAttribute("checked", aIsOffline);
> +    if (document.getElementById('appmenu_goOffline'))

Please use double quotes for the strings.

::: mail/base/content/mailWindowOverlay.js
@@ +191,5 @@
>      messagePaneMenuItem.disabled = accountCentralDisplayed;
>    }
>  
> +  if (document.getElementById("appmenu_showMessage")) {
> +    let messagePaneAppMenuItem = document.getElementById("appmenu_showMessage");

Please swap it like:
let messagePaneAppMenuItem = document.getElementById("appmenu_showMessage");
if (messagePaneAppMenuItem && messagePaneAppMenuItem.hidden) ..

@@ +204,5 @@
>    if (!folderPaneMenuItem.hidden) { // Hidden in the standalone msg window.
>      folderPaneMenuItem.setAttribute("checked", gFolderDisplay.folderPaneVisible);
>    }
>  
>    let folderPaneAppMenuItem = document.getElementById("appmenu_showFolderPane");

Doesn't this one and other appmenu_* elements below need to be checked for existence too?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: noAppMenuErrors.patch

(In reply to :aceman from comment #2)
> Comment on attachment 8876380 [details] [diff] [review]
> noAppMenuErrors.patch
> 
> Review of attachment 8876380 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/base/content/mail-offline.js
> @@ +203,5 @@
> >     */
> >    updateOfflineUI: function(aIsOffline)
> >    {
> >      document.getElementById('goOfflineMenuItem').setAttribute("checked", aIsOffline);
> > +    if (document.getElementById('appmenu_goOffline'))
> 
> Please use double quotes for the strings.

mail-offline.js has a mixture of using single- and double quotes. I changed now the whole function block to double quotes.

> ::: mail/base/content/mailWindowOverlay.js
> @@ +191,5 @@
> >      messagePaneMenuItem.disabled = accountCentralDisplayed;
> >    }
> >  
> > +  if (document.getElementById("appmenu_showMessage")) {
> > +    let messagePaneAppMenuItem = document.getElementById("appmenu_showMessage");
> 
> Please swap it like:
> let messagePaneAppMenuItem = document.getElementById("appmenu_showMessage");
> if (messagePaneAppMenuItem && messagePaneAppMenuItem.hidden) ..

Done.

> @@ +204,5 @@
> >    if (!folderPaneMenuItem.hidden) { // Hidden in the standalone msg window.
> >      folderPaneMenuItem.setAttribute("checked", gFolderDisplay.folderPaneVisible);
> >    }
> >  
> >    let folderPaneAppMenuItem = document.getElementById("appmenu_showFolderPane");
> 
> Doesn't this one and other appmenu_* elements below need to be checked for
> existence too?

I checked all menus and got no additional errors.

Comment 4

[:aceman]

Comment on attachment 8876393 [details] [diff] [review]
noAppMenuErrors.patch

Review of attachment 8876393 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Richard Marti (:Paenglab)]

Thanks too.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/c6db8440799e6a96455f30ab0ff592501a881d30