1373535 - confusing search preference results.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Alice0775 White]

Attachment: screenshot

Reproducible: always

Steps To Reproduce:
1. Open preference
2. Search "font" without " marks

Actual Results:
See attached screenshot

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Hi Alice,

Thanks for reporting this!

Could you tell us more details about what's your expected results?

IIUC, the `font` of `Default font` doesn't highlight as expected in your screenshot.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

We can see the `font` of `Default font` is able to be highlighted in my local Nightly build. I'd suspect that issue has been fixed in latest Nightly, so probably you can update your Nightly again to see what happen.

Thanks

Comment 3

[Alice0775 White]

highlite above [Advanced] button is wrong. There should be nothing.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Hi Alice,

I'd like to close this bug with `Resolved Invalid` if you don't mind since I think the tooltip above [Advance] button is by design. 

The floated tooltip on the button which indicates that there are matched results in related sub-dialog after clicking the button.

Feel free to reopen this issue or ask me anything if you are still not clear. Thank you :)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Ricky Chien [:rickychien] from comment #4)
> The floated tooltip on the button which indicates that there are matched
> results in related sub-dialog after clicking the button.

In this case, tooltip highlights the fact the title of the sub-dialog is "Fonts".

Comment 6

[Alice0775 White]

I reopen this and change summary.

This behavior is not intuitive. Even if it is explained, I can not understand its necessity.
The floating results cumbersome.  
It is not consistency with Find Page Highlight.
I confuse.

Comment 7

[Alice0775 White]

Request uiwanted,
If you want indicating such hidden matching results, I think it is better to highlight(emphasis border etc) the whole entire button.
I this case [Advanced].

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Thank you Alice! As you described, your question seems to relate UX consistency. Let's discuss that with UX for more details.

Tina, could you take a look at comment 6? thanks!

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Alice, could you tell us why do you feel the tooltip causes inconsistency with Find Page Highlight?

Comment 10

[Alice0775 White]

(In reply to Ricky Chien [:rickychien] from comment #9)
> Alice, could you tell us why do you feel the tooltip causes inconsistency
> with Find Page Highlight?

No tooltip with Find Page Highlight.

For example, find "modify" in https://developer.mozilla.org/en-US/Add-ons/WebExtensions ,
there are no tooltip at left sidebar menu "How to".


And see attachment 8878363 [details],  It does not look like a tool tip for me. It is almost of same as word highlight.
Because, ordinary tooltip has border. And the arrow is too small compared to other tooltips(such as form validation).

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Per discussion with Helen, we're going to add a border surrounding tooltip so that user can recognize tooltip more easily.

Helen, can you provide the latest visual spec? Thanks

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1373535 - Add border surrounding search tooltip itself

Review commit: https://reviewboard.mozilla.org/r/152068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152068/

Comment 13

[Helen Huang [:HHuang]]

Hi Ricky, here's the link https://mozilla.invisionapp.com/share/ZDAGPK3AF#/219340982_7-1_Visual
Thanks for your help!

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8880715 [details]
Bug 1373535 - Add border surrounding search tooltip itself

https://reviewboard.mozilla.org/r/152068/#review157314

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ade74b19771
Add border surrounding search tooltip itself r=jaws

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ade74b19771

Comment 17

[Md. Majedul islam]

I have reproduced this bug with nightly 6.0a1 (2017-06-15) on ubuntu 16.04(64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1 as per comment 11 .

Build ID 	20170627100221
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 18

[Azmina]

I have reproduce this bug with Nightly 56.0a1 (2017-06-15) on Windows 8.1 (64 Bit).

This bug's fix is verified on Latest Nightly 56.0a1.

Build ID : 20170627030209
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170628]

Comment 19

[Md. Majedul islam]

As per Comment 17 and Comment 18, I am marking this bug as verified fixed.