1374902 - stylo: Have unprefixed :fullscreen pseudo-class guarded behind full-screen-api.unprefix.enabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

:fullscreen pseudo-class should not take effect in document stylesheet if unprefixed Fullscreen API is not enabled.

It seems there is no test currently checking this. We should also add a test to dom/html/test/file_fullscreen-unprefix-disabled.html to ensure we check this properly.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

We don't want to unintentionally ship unprefixed Fullscreen things.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

This is something I'm familiar with. I would take care of this.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1374902 - Check pref when parsing :fullscreen pseudo-class.

Review commit: https://reviewboard.mozilla.org/r/163740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163740/

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Comment on attachment 8892749 [details]
Bug 1374902 - Check pref when parsing :fullscreen pseudo-class.

https://reviewboard.mozilla.org/r/163740/#review169798

This looks good to me. However, I just landed bug 1381851 which conflict with this patch. You'll need to rebase. Sorry about that.

Also, gecko uses CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME for :fullscreen at [1]. I left a comment on servo at [2]. You might want to add it accordingly if it's suitable, and remove the TODOs.

[1] http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/layout/style/nsCSSPseudoClassList.h#173
[2] https://github.com/servo/servo/blob/585c00f23559e9cf5dea288852515fd001bc1c43/components/style/gecko/non_ts_pseudo_class_list.rs#L64-L66

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8892749 [details]
Bug 1374902 - Check pref when parsing :fullscreen pseudo-class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163740/diff/1-2/

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Comment on attachment 8892749 [details]
Bug 1374902 - Check pref when parsing :fullscreen pseudo-class.

https://reviewboard.mozilla.org/r/163740/#review173294

Sorry for the delay. This looks good to me!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/970be3668e1e
Check pref when parsing :fullscreen pseudo-class. r=TYLin

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/970be3668e1e