Closed Bug 1375224 Opened 7 years ago Closed 7 years ago

Remove use of <style scoped> from SelectParentHelper.jsm

Categories

(Core :: Layout: Form Controls, enhancement)

Product:
Core
Component:
Layout: Form Controls
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm.
59 bytes, text/x-review-board-request
mconley
: review+
Sylvestre
: approval-mozilla-release+
Details 
Bug 1345702 is removing support for <style scoped>, and thus we should stop using the feature.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8880103 [details]
Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm.

https://reviewboard.mozilla.org/r/151470/#review156870

Thanks!
Attachment #8880103 - Flags: review?(mconley) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/619c20245f8f
Remove use of <style scoped> from SelectParentHelper.jsm. r=mconley
https://hg.mozilla.org/mozilla-central/rev/619c20245f8f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Blocks: 1388682
This is impacting the release and give an weird impression for users impacted by the bug.
I am considering taking it to release. Could you please fill the uplift request? Thanks
Flags: needinfo?(mconley)
Flags: needinfo?(jaws)
Go to build for 55.0.2, tomorrow Monday
Comment on attachment 8880103 [details]
Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm.

Approval Request Comment
[Feature/Bug causing the regression]: We have seen bug 1389870 and bug 1388682 on release already because this wasn't uplifted
[User impact if declined]: See above
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Changes from using <style scoped> to using a CSS ID selector for the styles which are equivalent to <style scoped>
[String changes made/needed]: none

I have tested that this patch applies cleanly to mozilla-release and that the testcase in bug 1389870 is fixed. I was unable to reproduce the testcase in bug 1388682 without this patch (possibly because I need to test with Classic mode which Windows 10 doesn't have). I tested using the following URL:
data:text/html,<html><style>select {background-color: red;}</style><body><select id="test"><option value="1">opt 1</option><option value="2">opt 2</option><option value="3">opt 3</option></select></body></html>

With that being said, I do not have any doubt that uplifting this patch to release will fix both bugs.
Flags: needinfo?(mconley)
Flags: needinfo?(jaws)
Attachment #8880103 - Flags: approval-mozilla-release?
Comment on attachment 8880103 [details]
Bug 1375224 - Remove use of <style scoped> from SelectParentHelper.jsm.

Thanks, let's take it for the 55.0.2 release
Attachment #8880103 - Flags: approval-mozilla-release? → approval-mozilla-release+
We tried to reproduce this issue on 55.0.2-build1 as well, but we didn't managed to do so. Therefore we can't confirm if this issue was fixed or not.
Added to the release notes with
"Fix a regression with the popup menu"
Don't hesitate if you have a better wording
No longer blocks: 1345702
Blocks: 1444905
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: