1375680 - Port bug 1367813 to TB - rename readUserPrefs to readUserPrefsFromFile

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1375680-user-prefs-from-file.patch

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/213e1c2f2be591235563ac6f88acaeee4ac4c639

Comment 3

[:aceman]

Comment on attachment 8880592 [details] [diff] [review]
1375680-user-prefs-from-file.patch

Review of attachment 8880592 [details] [diff] [review]:
-----------------------------------------------------------------

What about https://dxr.mozilla.org/comm-central/source/mailnews/addrbook/test/unit/test_bug534822.js#17 and https://dxr.mozilla.org/comm-central/source/suite/profile/migration.js#414 ?

Comment 4

[Jorg K (CEST = GMT+2)]

Sigh, I missed those due to case sensitive DXR.

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/15a298a57d1f9d474a78545be4688ad604c47ea6

Comment 6

[Richard Marti (:Paenglab)]

Bug 1367813 is backed-out.

Comment 7

[Jorg K (CEST = GMT+2)]

Thanks, I'll take appropriate action.

Comment 8

[Jorg K (CEST = GMT+2)]

Backout:
https://hg.mozilla.org/comm-central/rev/36a56528987dc511a35d5d5128c7a300fac00c83

Next time I'll land it in on changeset before midnight ;-)

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1375680-user-prefs-from-file.patch - C++ and JS parts combined

Let's land this in due course.

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/2983f04886b61661fc69d2eb5262084f902e0486

Comment 12

[Jorg K (CEST = GMT+2)]

Attachment: 1360915-test-expectations.patch (v1).

I think the tests need to be adjusted like this.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c6accc254899fd6bf2b89aa2673731d0d0345bdd

Both tests pass locally on Windows, so let's see what the other platforms do.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 8882903 [details] [diff] [review]
1360915-test-expectations.patch (v1).

Oops, attached this to the wrong bug.