1375876 - clang-format NSPR

Status: RESOLVED WONTFIX

(NSPR :: NSPR, enhancement)

Description

[Kai Engert [:KaiE:]]

It would be nice to reformat the NSPR code, like we did with NSS.

Comment 1

[Kai Engert [:KaiE:]]

I'd like to do this soon. But before that, we need to complete bug 1535665, to ensure Ludo's patches don't bitrot.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: list

Mike, I'd like to reformat NSPR in the same way as we do for NSS, same rules, same version of clang-format.
Are you OK with that? Can I use your r+ for that change, or maybe I don't need a review at all?
I've already tested the reformatted code with both NSS test suite and Firefox, and didn't see any regressions.

I'm attaching the list of files that will be touched.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: nspr-clang-control.patch

This is the copied .clang-format file from NSS, and a copied and modified version of the run_clang_format.sh file.

The only modification to run_clang_format.sh is the list of excluded directories.

This script won't be used automatically, but can executed on demand.

In a second step we can consider to hook it up to the NSS taskcluster automation.

Comment 4

[Mike Hommey [:glandium]]

What does the formatting look like?

Comment 5

[Kai Engert [:KaiE:]]

Mike, I had sent you an email with subject "nspr-reformat.patch", did you get it?

It's pretty large, I didn't want to attach it in bugzilla.

Comment 6

[Mike Hommey [:glandium]]

Can you put it on phabricator?

Comment 7

[Kai Engert [:KaiE:]]

Attachment: Bug 1375876 - clang-format NSPR. r=glandium

Comment 8

[Kai Engert [:KaiE:]]

Done. I guess it's OK for skimming and having a look. But reviewing the individual changes would be overkill.

The goal is that we'd not touch the formatting ourselves, but rely on clang-format to decide how it looks. The same is done for NSS.

Comment 9

[Kai Engert [:KaiE:]]

This is more work than I thought. I'd like to start with bug 1581890 instead.

Comment 10

[Kai Engert [:KaiE:]]

I'm not happy how clang-format behaves with NSPR.
I like the artistic style utility better, because it's less invasive.

Given that NSPR isn't developed very actively, it might be sufficient to a one-time cleanup, and only occasionally re-run a prettier.
Therefore I'd like to close this for now, and only do the work in bug 1581890.