1376549 - APZ: Dispatch keyboard shortcuts hardcoded in ESM to content

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

We need to disable async keyboard scrolling when an event is processed in APZ that could change the focus until that event is processed by content and the focus is reconfirmed.

We are doing this for all non keyboard events processed by APZ, but there are some key events that we don't consider focus changing (like Tab) that should be.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: shortcut-tabs.patch

The default action of tab keys is hardcoded in EventStateManager::PostHandleKeyEvent [1]. This patch hardcodes keyboard shortcuts that will dispatch input to content when it is a tab.

It'd be nice to have a way to not hardcode this, but this seems relatively contained.

[1] http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/dom/events/EventStateManager.cpp#2848

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8882061 [details] [diff] [review]
shortcut-tabs.patch

Review of attachment 8882061 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but I'd prefer to call the function AppendHardcodedShortcuts since it deals with F6 in addition to tab, and the name makes it a bit more obvious why we are doing it.

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Lowering the scope of the bug into something that can be landed now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89be529dbce8
Prevent APZ handling of keyboard shortcuts hardcoded in ESM. r=kats

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/89be529dbce8