1376838 - Enable hardware VP9 decoding on Nvidia GPUs

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should enable VP9 hardware decoding on Nvidia GPUs.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1376838: Revert "Bug 1360006: Whitelist VP9 decoder to intel GPU only."

This reverts commit 77f2dd5563d2c3e9ad7ada388036f1846c1e2107

Review commit: https://reviewboard.mozilla.org/r/152912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152912/

Comment 2

[Jean-Yves Avenard [:jya]]

[Tracking Requested - why for this release]: we disabled VP9 hardware decoding on nvidia GPU thinking there was an issue with those cards. But it turned out to be something else (see bug 1371290)

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8881836 [details]
Bug 1376838: Revert "Bug 1360006: Whitelist VP9 decoder to intel GPU only."

https://reviewboard.mozilla.org/r/152912/#review158148

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba616afa8125
Revert "Bug 1360006: Whitelist VP9 decoder to intel GPU only." r=cpearce

Comment 5

[Julien Cristau [:jcristau]]

Why does this need to go in 55?

Comment 6

[Julien Cristau [:jcristau]]

I don't think I need to track this.

Comment 7

[Jean-Yves Avenard [:jya]]

(In reply to Julien Cristau [:jcristau] from comment #5)
> Why does this need to go in 55?

Because we disabled it in 55 when it didn't have to be.

Chrome enabled this features many features ago and give them a significant advantage when it comes to watching youtube.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba616afa8125

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8881836 [details]
Bug 1376838: Revert "Bug 1360006: Whitelist VP9 decoder to intel GPU only."

Approval Request Comment
[Feature/Bug causing the regression]: 1360006
[User impact if declined]: High CPU usage on high-end machines watching YouTube
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Go to youtube.com and select a 4K videos. You need a machine with a nvidia pascal gpu (10xx) or nvidia 980/nvidia 960GT (not mobile version). See that CPU usage stays below 5%.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no. We've enabled this feature for intel processors already.
[Why is the change risky/not risky?]: the change has been confirmed by users that the improvement was significant
[String changes made/needed]:

Comment 10

[Julien Cristau [:jcristau]]

Just to make sure.. does this change disable media.wmf.vp9.enabled on purpose?

Comment 11

[Jean-Yves Avenard [:jya]]

Oh good point, were supposed to enable this on beta too !

Comment 12

[Jean-Yves Avenard [:jya]]

:jcristau, so this bug and bug 1378508 are now ready for beta uplift.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8881836 [details]
Bug 1376838: Revert "Bug 1360006: Whitelist VP9 decoder to intel GPU only."

enable vp9 decoder on nvidia gpus, beta55+

Should be in 55.0b8 along with 1378508

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e8e6d4c68bd3