1377785 - Identity block and address separator is using other green tint compared to pinlock green tint with HTTPS

Status: VERIFIED WORKSFORME

(Firefox :: Theme, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Go to this website page - https://bugzilla.mozilla.org/
and see that identity block and address separator is green instead of grey



"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/07/2017-07-01-03-02-03-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/07/2017-07-02-03-02-04-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=587daa4bdc4b40b7053f4ca3b74723ca747f3b52&tochange=4d3de12dcdc539f14fcb06539da39fa7176c8955

Probably caused by:
bug #1363502 [Firefox:Theme]-Implement new identity block appearance
bug #1367439 [Firefox:Theme]-Update toolbar background colors on OS X and Windows, update customize mode background to match
bug #1350210 [Firefox:Toolbars and Customization]-Add setting for Compact and Touch theme modes (a.k.a. "Density" control)

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug (500%).png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug.png

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug (500%).png

Comment 5

[Dale Harvey (:daleharvey)]

This is also as per spec https://people-mozilla.org/~shorlander/projects/photon/Mockups/macOS.html

VirtualMan we are making changes as part of the photon redesign, is there anything we can do to help you know which changes are intentional so we dont have bugs files for intentional changes? Cheers

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Dale Harvey (:daleharvey) - There is no any separators in any mockups:
https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-7.html
https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-10.html
https://people-mozilla.org/~shorlander/projects/photon/Mockups/macOS.html
https://people-mozilla.org/~shorlander/projects/photon/Mockups/linux.html
or I'm missing something?

Comment 7

[Darkspirit]

https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/229940647
Please scroll to the bottom.
I can confirm, that padlock, Text and seperator* have those colors from the mockup.
*) That vertical line is #87dc7e, which could be #12BC00 @ 50% alpha.

Comment 8

[:Gijs (he/him)]

Closing per comment 5 and comment 7.

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Darkspirit from comment #7)
> https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/229940647
> Please scroll to the bottom.
> I can confirm, that padlock, Text and seperator* have those colors from the
> mockup.
> *) That vertical line is #87dc7e, which could be #12BC00 @ 50% alpha.

Thank you very much for the link.



(In reply to :Gijs from comment #8)
> Closing per comment 5 and comment 7.

I hope you don't mind if I I reopen this bug and track tint issue here,
as separator between identity block and address is using 82D779 in my case, instead of 12BC00 like on mockups.

Comment 10

[Darkspirit]

(In reply to Virtual_ManPL [:Virtual] - from comment #9)
> is using 82D779 in my case, instead of 12BC00 like on mockups.
Your separator seems to be correct. Your locationbar background is #ffeedc because of your custom orange theme.
Note that the mockup does not say "12BC00", but rather "#12BC00 @ 50% alpha", so with a bit transparency.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Darkspirit - I have 82D779, even if I disable my Persona/Light Theme/Appearance and use "Default" one.

Comment 12

[Dale Harvey (:daleharvey)]

However you pick it up with your color picker, its 'rgba(18, 188, 0, .5)' (http://searchfox.org/mozilla-central/source/browser/themes/shared/identity-block/identity-block.inc.css#55) which is as the spec is

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

True, so everything is working as intended.
Thank you Dale Harvey (:daleharvey) very much for very detailed explanations!

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Also thank you Darkspirit very much too!