Closed Bug 1378163 Opened 7 years ago Closed 7 years ago

Permanent failure on Cedar: browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

Snipped from the log:

07:50:04     INFO - Entering test bound checkAllTheFiles
07:50:04     INFO - Buffered messages finished
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 6, expected 0
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochikit/content/browser-test.js:test_is:967
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:615
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/chevron-animation.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/device-desktop.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/email-link.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/link.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/page-action.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - Not taking screenshot here: see the one that was previously logged
07:50:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/tabbrowser/indicator-tab-attention.svg - 
07:50:04     INFO - Stack trace:
07:50:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:617
07:50:04     INFO - ignored unused whitelist entry: chrome://xslt-qa/content/buster/result-view.xul
07:50:04     INFO - ignored unused whitelist entry: chrome://xslt-qa/content/xslt-qa-overlay.xul
07:50:04     INFO - ignored unused whitelist entry: chrome://global/locale/crashes.dtd
07:50:04     INFO - ignored unused whitelist entry: chrome://global/locale/crashes.properties
07:50:04     INFO - ignored unused whitelist entry: resource://app/blocklist.xml
07:50:04     INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
07:50:04     INFO - ignored unused whitelist entry: resource://gre/res/test.properties
07:50:04     INFO - missing file with code reference: chrome://flyweb/content/icon-64.png
07:50:04     INFO - missing file with code reference: chrome://communicator/content/directory/directory.xul
07:50:04     INFO - missing file with code reference: chrome://help/content/help.js
07:50:04     INFO - missing file with code reference: resource://gre/modules/E10SUtils.jsm
07:50:04     INFO - missing file with code reference: chrome://global/skin/expander.css
07:50:04     INFO - missing file with code reference: chrome://global/skin/printPreview.css
07:50:04     INFO - missing file with code reference: resource://services-sync/)%20==%200)%20%7B
07:50:04     INFO - missing file with code reference: resource://gre/modules/worker/myModule.js
07:50:04     INFO - missing file with code reference: resource://gre/modules/workers/SimpleTest.js
07:50:04     INFO - missing file with code reference: resource://gre/modules/workers/Logger.js
07:50:04     INFO - missing file with code reference: resource://pdf.js.components/
07:50:04     INFO - missing file with code reference: resource://gre/modules/glenn.htm
07:50:04     INFO - missing file with code reference: resource://gre/modules/jane.html
07:50:04     INFO - missing file with code reference: resource://gre/modules/jane.jpeg
07:50:04     INFO - missing file with code reference: resource://gre/modules/glenn.html
07:50:04     INFO - missing file with code reference: chrome://gfxsanity/content/sanityparent.html
07:50:04     INFO - missing file with code reference: resource://gre/modules/Messaging.jsm
07:50:04     INFO - missing file with code reference: resource://addon-1/data/index.html
07:50:04     INFO - missing file with code reference: resource://addon-1/data/main.html
07:50:04     INFO - missing file with code reference: resource://gre/modules/WindowsRegistry.jsm
07:50:04     INFO - missing file with code reference: resource://gre/modules/OSCrypto_win.js
07:50:04     INFO - missing file with code reference: resource://gre/modules/osfile/osfile_win_allthreads.jsm
07:50:04     INFO - missing file with code reference: resource://gre/modules/subprocess/subprocess_win.jsm
07:50:04     INFO - missing file with code reference: resource://gre/modules/DownloadImport.jsm
07:50:04     INFO - missing file with code reference: resource://android/
07:50:04     INFO - missing file with code reference: resource://gre/modules/PushServiceAndroidGCM.jsm
07:50:04     INFO - missing file with code reference: chrome://global/skin/plugins.css
07:50:04     INFO - missing file with code reference: chrome://browser/skin/customizableui/density-normal.svg
07:50:04     INFO - missing file with code reference: chrome://browser/skin/customizableui/density-compact.svg
07:50:04     INFO - missing file with code reference: chrome://browser/skin/customizableui/density-touch.svg
07:50:04     INFO - missing file with code reference: chrome://browser/locale/preferences.properties
07:50:04     INFO - missing file with code reference: resource://gre/modules/WebNavigationFrames.js
07:50:04     INFO - missing file with code reference: resource:///modules/WindowsPreviewPerTab.jsm
07:50:04     INFO - missing file with code reference: resource:///modules/Windows8WindowFrameColor.jsm
07:50:04     INFO - missing file with code reference: resource://testing-common/content-task.js%20line%2052%20%3E%20eval
07:50:04     INFO - missing file with code reference: resource://gre/modules/systemlibs.js
07:50:04     INFO - missing file with code reference: resource:///modules/WindowsJumpLists.jsm
07:50:04     INFO - missing file with code reference: chrome://branding/content/icon
07:50:04     INFO - missing file with code reference: chrome://b2g/content/shell.html
07:50:04     INFO - missing file with code reference: chrome://browser/content/pref/pref.xul
07:50:04     INFO - missing file with code reference: chrome://browser/content/preferences/preferences.xul
07:50:04     INFO - missing file with code reference: resource://test/
07:50:04     INFO - missing file with code reference: resource://app/some/link.html
07:50:04     INFO - missing file with code reference: chrome://browser/locale/uiDensity.properties
07:50:04     INFO - missing file with code reference: resource://gre/modules/SystemAppProxy.jsm
07:50:04     INFO - missing file with code reference: chrome://browser/content/extension-win-panel.css
07:50:04     INFO - missing file with code reference: chrome://browser/content/webrtcIndicator.xul
07:50:04     INFO - missing file with code reference: resource://screenshots-addon/
07:50:04     INFO - Leaving test bound checkAllTheFiles
07:50:04     INFO - Console message: No chrome package registered for chrome://flyweb/content/icon-64.png
07:50:04     INFO - Console message: No chrome package registered for chrome://navigator/content/navigator.xul
07:50:04     INFO - Console message: No chrome package registered for chrome://communicator/content/directory/directory.xul
07:50:04     INFO - Console message: No chrome package registered for chrome://help/content/help.js
07:50:04     INFO - Console message: No chrome package registered for chrome://gfxsanity/content/sanityparent.html
07:50:04     INFO - Console message: No chrome package registered for chrome://b2g/content/shell.html
07:50:04     INFO - GECKO(1710) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
07:50:04     INFO - GECKO(1710) | MEMORY STAT | vsize 4736MB | residentFast 715MB | heapAllocated 477MB
07:50:04     INFO - TEST-OK | browser/base/content/test/static/browser_all_files_referenced.js | took 9421ms
07:50:05     INFO - checking window state
07:50:05     INFO - TEST-START | browser/base/content/test/static/browser_misused_characters_in_strings.js
07:50:05     INFO - GECKO(1710) | MEMORY STAT | vsize 4745MB | residentFast 725MB | heapAllocated 457MB
07:50:05     INFO - TEST-OK | browser/base/content/test/static/browser_misused_characters_in_strings.js | took 959ms
07:50:06     INFO - checking window state
07:50:06     INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js
07:50:06     INFO - Not taking screenshot here: see the one that was previously logged
07:50:06     INFO - <snipped 21 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
07:50:06     INFO - Buffered messages logged at 07:50:06
07:50:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-normal.svg referenced from chrome://browser/skin/browser.css - 
07:50:06     INFO - Stack trace:
07:50:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:340
07:50:06     INFO - Not taking screenshot here: see the one that was previously logged
07:50:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-compact.svg referenced from chrome://browser/skin/browser.css - 
07:50:06     INFO - Stack trace:
07:50:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:340
07:50:06     INFO - Not taking screenshot here: see the one that was previously logged
07:50:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://browser/skin/customizableui/density-touch.svg referenced from chrome://browser/skin/browser.css - 
07:50:06     INFO - Stack trace:
07:50:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:340
07:50:06     INFO - Ignored error for resource://gre-resources/html.css because of filter.
Summary: Permanent failure browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files → Permanent failure on Cedar: browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files
Blocks: 1378197
I suspect we're just going to need to update the whitelist here of files that can be unreferenced in the non-Photon build configuration.

Here's an easier to read list of unreferenced files being complained about here, along with the bugs that added them:

Bug 1375152 - chrome://browser/skin/chevron-animation.svg
Bug 1363182 - chrome://browser/skin/device-desktop.svg
Bug 1355323 - chrome://browser/skin/email-link.svg
Bug 1367587 - chrome://browser/skin/link.svg
Bug 1355322 - chrome://browser/skin/page-action.svg
Bug 1375893 - chrome://browser/skin/tabbrowser/indicator-tab-attention.svg
Okay, I think I've sorted this:

chrome://browser/skin/chevron-animation.svg:
  Recently added in bug 1375152. Need to wrap the jar.mn entry in MOZ_PHOTON_ANIMATIONS, since this is only ever used in Photon.

chrome://browser/skin/device-desktop.svg
chrome://browser/skin/email-link.svg
chrome://browser/skin/link.svg
chrome://browser/skin/page-action.svg
  Moved CSS rules into an ifdef recently in bug 	1377165. The jar.mn entries should also go behind MOZ_PHOTON_THEME.

chrome://browser/skin/tabbrowser/indicator-tab-attention.svg:
  Recently added in bug 1375893. The jar.mn entry needs to be wrapped by MOZ_PHOTON_THEME.
Assignee: nobody → mconley
Comment on attachment 8883381 [details]
Bug 1378163 - Only package images for Photon when Photon is enabled.

https://reviewboard.mozilla.org/r/154264/#review159356
Attachment #8883381 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79df9efc194b
Only package images for Photon when Photon is enabled. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/79df9efc194b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: