Closed
Bug 1378442
Opened 7 years ago
Closed 7 years ago
Move Win64 profiler hooks to profiler_start
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
6.97 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 1372375 caused a lot of regressions during shutdown in general browser usage. I'd like to go back to having the hooks be initialized for profiling scenarios only, but we need to be careful to preserve the spirit of bug 1372375 and avoid doing work in the profiler's critical section. Based on Markus's suggestion and confirmed by local debugging, I think profiler_start is a good place.
Assignee: nobody → dmajor
Attachment #8883634 -
Flags: review?(mstange)
|
||
Updated•7 years ago
|
Attachment #8883634 -
Flags: review?(mstange) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a199c96110ca Move Win64 profiler hooks to profiler_start. r=mstange
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a199c96110ca
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•