1380014 - Share fonts between BlobImage and WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

We can use FontKeys to share Fonts across the process boundary and avoid duplicating the data with WebRender.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Rough cut of something that does this.

This doesn't retain the UnscaledFonts between paints which causes a bunch of overhead because the situation with FreeType is not thread safe. However it gets rid of the serialization.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: V2

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Redo the serialization to make doing blob image invalidation easier

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This is probably going to be a nightly blocker.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Expose GetFontKeyForUnscaledFont

We'll use this to share fonts with BlobImages

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add the ability to record UnscaledFonts by index

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Share fonts with WebRender

This changes the serialization format a little bit. We now have an index at the end of the blob. This is currently used to store a list of the used font keys. In the future we'll add rects and can use it for invalidation.

Comment 8

[Lee Salzman [:lsalzman]]

Comment on attachment 8922393 [details] [diff] [review]
Expose GetFontKeyForUnscaledFont

You should make sure you bail out inside GetFontKeyForScaledFont if GetFontKeyForUnscaledFont returns a null FontKey, instead of proceeding to create a FontInstanceKey with the null FontKey.

Comment 9

[Lee Salzman [:lsalzman]]

Comment on attachment 8922396 [details] [diff] [review]
Share fonts with WebRender

In answer to the query in the patch, Linux always used FontType::FONTCONFIG. Only Android uses FontType::FREETYPE.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Attachment: Expose GetFontKeyForUnscaledFont

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/630968b6201e
Expose GetFontKeyForUnscaledFont. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/006a45a50d90
Add the ability to record UnscaledFonts by index. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a824a8a2277
Share fonts with WebRender. r=lsalzman

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Attachment: Keep the unscaled font alive

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40868b71690c
Keep the unscaled font alive. r=lsalzman

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/630968b6201e
https://hg.mozilla.org/mozilla-central/rev/006a45a50d90
https://hg.mozilla.org/mozilla-central/rev/2a824a8a2277
https://hg.mozilla.org/mozilla-central/rev/40868b71690c

Comment 15

[Kartikaya Gupta (email:[e-mail])]

These patches changed webrender_bindings but didn't regen the ffi header. Now my WR update try pushes are failing because the regen'd header doesn't compile.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5640a62bc5b1a7535f21691ba2afb83e6ff97d7a
The changes that show up in the regen'd file as a result of this: https://hg.mozilla.org/try/rev/4f965e0ad18da6125afd0886a5784e2b4970169e

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Looking...

Comment 17

[Jeff Muizelaar [:jrmuizel]]

Attachment: Fix up webrender bindings

If you like this you can land it if you want it earlier than I get around to landing it. (I'm going to be out for most of day)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f89b4a42ac3c
Fix up the webrender bindings. r=kats

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f89b4a42ac3c