stylo: Enable Stylo tests on all desktop platforms: Linux32, Linux64, Win32, Win64, Mac

ASSIGNED
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
ASSIGNED
13 days ago
30 minutes ago

People

(Reporter: cpeterson, Assigned: jryans)

Tracking

(Depends on: 3 bugs, Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

13 days ago
Now that we have Stylo support in Nightly builds for Linux64, Mac, and Windows, we should run our Stylo tests on those platforms. We should run all the same test configurations as we do for linux64-stylo on inbound, autoland, and central:

https://docs.google.com/spreadsheets/d/1HmBsxrEpFfCgpLBG5Mvj5wEA9oEq5N8m4cxQYsSo4S8/edit#gid=1737640065

We don't need to run the Mac and Windows tests in Stylo sequential mode, just parallel mode.

Because we don't have custom Stylo-enabled builds for Mac, Windows, or Linux32 like we do for linux64-stylo, this bug depends on bug 1374748 to enable automation to run Stylo tests using regular builds and the STYLO_FORCE_ENABLED=1 environment variable.
(Assignee)

Comment 1

13 days ago
Here's a first attempt to see how green things are running the regular desktop test configurations, but with Stylo parallel forced on:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaf2a5c4c116336d4c632ec6c94390a78b4b4d8c
(Reporter)

Updated

13 days ago
Blocks: 1380086
(Assignee)

Comment 2

10 days ago
New attempt after landing bug 1380082 so that test annotations are respected:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94b3ff1cbae742e73cb0f6537dd8dc0d40bc32ad
Previous attempt was too noisy with too many extra test jobs we don't yet want for Stylo.  Here's a more focused approach with same test set we're using on Linux:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7213937697abb7f2b7f807afbb31b08488acda5
(Assignee)

Updated

6 days ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Looks like we got valid results from the Mac run, but for Windows that build crashed quite early when Stylo is used.  The latest central build appears to work for Stylo on Windows, so I'll rebase and try again.

This run is Windows only, since try is closed for Mac currently:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f096a3bd8433501a75c62f210ba3ce4f003620a4
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> Looks like we got valid results from the Mac run, but for Windows that build
> crashed quite early when Stylo is used.

Perhaps that was bug 1382019?
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #5)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> > Looks like we got valid results from the Mac run, but for Windows that build
> > crashed quite early when Stylo is used.
> 
> Perhaps that was bug 1382019?

Right, that was my primary suspect.  I didn't realize until just now that that crash was Windows only, but since it appears to be, it seems like the right bug here.
Depends on: 1382019
(Assignee)

Updated

5 days ago
Depends on: 1382322
Okay, making progress.  Windows 64 is returning good data, but something's still busted for Windows 32, so I'll check that soon.

I also noticed WPT is failing for these new platforms because the annotations are Linux specific.  Filed bug 1382322 to clean that up.
Windows 32-bit is hitting a new crash (bug 1382190), so I'll ignore it in the testing runs for now.
Depends on: 1382190
https://treeherder.mozilla.org/#/jobs?repo=try&revision=723dfa95bd41e7217ed0ed333d52a6e25801f839
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74dab813af8b25642919c747cd0cef9b3f25500e
This bug is focused on unit / integration tests only, so it will ignore Talos for the moment.  See related bug 1383789 about expanding Talos coverage.
See Also: → bug 1383789
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

30 minutes ago
Depends on: 1383845
You need to log in before you can comment on or make changes to this bug.