1380220 - Talos session restore loads the wrong session file

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Bao Quan [:beekill]]

Since the bug 934967 is solved, the session file in Talos session restore will be migrated to sessionstore.jsonlz4. However, after a cycle completes, sessionstore.js is reinstalled but not sessionstore.jsonlz4. Therefore, the sessionstore.jsonlz4 is left and read in the next cycle.

Comment 1

[Bao Quan [:beekill]]

Attachment: Bug 1380220 - Add compressed version of session file in Talos session restore test to ensure Talos test read the correct session file.

Review commit: https://reviewboard.mozilla.org/r/156408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156408/

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8885550 [details]
Bug 1380220 - Add compressed version of session file in Talos session restore test to ensure Talos test read the correct session file.

https://reviewboard.mozilla.org/r/156408/#review161620

Comment 3

[Bao Quan [:beekill]]

The try server result seems fine. Can you land this?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65d2aefe6c6b
Add compressed version of session file in Talos session restore test to ensure Talos test read the correct session file. r=gbrown

Comment 5

[Geoff Brown [:gbrown]]

Sure. Thanks!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65d2aefe6c6b

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

some performance regressions from this change:
== Change summary for alert #7981 (as of July 13 2017 13:39 UTC) ==

Regressions:

  5%  sessionrestore_no_auto_restore windows7-32 opt e10s     891.29 -> 931.56
  2%  sessionrestore_no_auto_restore windows10-64 opt e10s    836.30 -> 855.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7981

I believe these are expected as we are changing the test, :beekill, can you confirm?

Comment 9

[Bao Quan [:beekill]]

Yeah I think so. The time spending in reading lz4 compression is usually longer compare to reading raw text file.

Comment 10

[Andreea Pavel [:apavel]]

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=163155794&repo=autoland&lineNumber=3123

Comment 11

[Intermittent Failures Robot]

1 failures in 675 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1380220&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 13

[Intermittent Failures Robot]

1 failures in 4275 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1380220&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 14

[Intermittent Failures Robot]

1 failures in 3376 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1380220&startday=2021-09-27&endday=2021-10-03&tree=all

Comment 15

[Mark Banner (:standard8)]

Re-closing. The intermittents here shouldn't have been referenced to this bug as this wasn't an intermittent failure issue.