Closed Bug 1382175 Opened 2 years ago Closed 2 years ago

[DateTimePicker] Fix time picker step and min/max regressions

Categories

(Core :: Layout: Form Controls, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1363672 implemented step feature for date picker, but it also broke time picker in the process.
Summary: [DateTimePicker] Fix time picker step regression → [DateTimePicker] Fix time picker step and min/max regressions
Comment on attachment 8887972 [details]
Bug 1382175 - Fix time picker step and min/max regressions.

https://reviewboard.mozilla.org/r/158804/#review164368

Looks good, but I figure this is probably something that automated tests probably should have caught... do we have an automated testing plan here?
Attachment #8887972 - Flags: review?(mconley) → review+
Comment on attachment 8887972 [details]
Bug 1382175 - Fix time picker step and min/max regressions.

https://reviewboard.mozilla.org/r/158804/#review164368

Yes automated tests should catch this… I'm working on tests covering the date picker, and should be easy to add some basic coverage for time picker as well.
Keywords: checkin-needed
P1 as it's regression
Priority: -- → P1
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/384002b17a52
Fix time picker step and min/max regressions. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/384002b17a52
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.