1382175 - [DateTimePicker] Fix time picker step and min/max regressions

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Scott Wu [:scottwu]]

Bug 1363672 implemented step feature for date picker, but it also broke time picker in the process.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1382175 - Fix time picker step and min/max regressions.

Bug 1363672 uses .getStep() to obtain the step size for an input element in ms,
so we won't need to do conversion anymore. Bug 1364026 uses .getMinimum() and
.getMaximum() to obtain min and max in ms, rather than strings.

Review commit: https://reviewboard.mozilla.org/r/158804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158804/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8887972 [details]
Bug 1382175 - Fix time picker step and min/max regressions.

https://reviewboard.mozilla.org/r/158804/#review164368

Looks good, but I figure this is probably something that automated tests probably should have caught... do we have an automated testing plan here?

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8887972 [details]
Bug 1382175 - Fix time picker step and min/max regressions.

https://reviewboard.mozilla.org/r/158804/#review164368

Yes automated tests should catch this… I'm working on tests covering the date picker, and should be easy to add some basic coverage for time picker as well.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

P1 as it's regression

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/384002b17a52
Fix time picker step and min/max regressions. r=mconley

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/384002b17a52