Closed Bug 1384895 Opened 7 years ago Closed 7 years ago

Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox56 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-visual])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1384893 +++

The icon is 16x16 rather than 18x18 and --toolbarbutton-icon-fill only makes sense in toolbars.
Flags: qe-verify-
Iteration: --- → 56.4 - Aug 1
Comment on attachment 8890812 [details]
Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill.

https://reviewboard.mozilla.org/r/162022/#review167310

This works for me but I should mention that on OSX the button is just blank, before and after this patch. Which is probably something I should make a bug about.
Attachment #8890812 - Flags: review?(jhofmann) → review+
hg error in cmd: hg pull gecko -r 152f4c7e4587a4381d9db724c34d46ebe0b43901: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32cff21188b7
Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill. r=johannh
(In reply to Johann Hofmann [:johannh] from comment #3)
> Comment on attachment 8890812 [details]
> Bug 1384895 - Manage Share Providers button icon is wrongly sized and
> shouldn't use --toolbarbutton-icon-fill.
> 
> https://reviewboard.mozilla.org/r/162022/#review167310
> 
> This works for me but I should mention that on OSX the button is just blank,
> before and after this patch. Which is probably something I should make a bug
> about.

filed bug 1384983
https://hg.mozilla.org/mozilla-central/rev/32cff21188b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.