1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1384893 +++

The icon is 16x16 rather than 18x18 and --toolbarbutton-icon-fill only makes sense in toolbars.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill.

The icon is 16x16 rather than 18x18 and --toolbarbutton-icon-fill only makes sense in toolbars.

Review commit: https://reviewboard.mozilla.org/r/162022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162022/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8890812 [details]
Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162022/diff/1-2/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8890812 [details]
Bug 1384895 - Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill.

https://reviewboard.mozilla.org/r/162022/#review167310

This works for me but I should mention that on OSX the button is just blank, before and after this patch. Which is probably something I should make a bug about.

Comment 4

[Mozilla Autoland]

hg error in cmd: hg pull gecko -r 152f4c7e4587a4381d9db724c34d46ebe0b43901: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32cff21188b7
Manage Share Providers button icon is wrongly sized and shouldn't use --toolbarbutton-icon-fill. r=johannh

Comment 6

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #3)
> Comment on attachment 8890812 [details]
> Bug 1384895 - Manage Share Providers button icon is wrongly sized and
> shouldn't use --toolbarbutton-icon-fill.
> 
> https://reviewboard.mozilla.org/r/162022/#review167310
> 
> This works for me but I should mention that on OSX the button is just blank,
> before and after this patch. Which is probably something I should make a bug
> about.

filed bug 1384983

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32cff21188b7