1385902 - "Find in Preferences" placeholder is truncated in French

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Théo Chevalier]

Attachment: Screenshot

On macOS and Linux, the placeholder text "Find in Preferences" is truncated in French (see screenshot), and we can’t easily shorter the translation.

Other locales may be affected, but it seems French is the longest for this string: https://transvision.mozfr.org/string/?entity=browser/chrome/browser/preferences/preferences.properties:searchInput.labelUnix&repo=central


We’re using a different, shorter string on Windows (Preferences vs. Options), so Windows builds are not affected.

Comment 1

[Helen Huang [:HHuang]]

From visual perspective, I suggest to extend the width of the search field to 240px in this case, so we can show the whole string, let me know if any questions!

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Per discussion with Helen, we finally decided to extend the width of search field to 230px but set display: none for the .textbox-search-icons to reduce extra space.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1385902 - Extend the width of preferences search field

Review commit: https://reviewboard.mozilla.org/r/163250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163250/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field

https://reviewboard.mozilla.org/r/163250/#review168980

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9432c692aae0
Extend the width of preferences search field r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9432c692aae0

Comment 7

[Deac Alin]

Attachment: Screenshots.zip

The issue is still reproducible on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 (ID 20170808114032) and Ubuntu 16.04 x64(ID 20170809043657). New screenshots attached.

Comment 8

[Francesco Lodolo [:flod]]

This one is fixed (on 56). See bug 1388348 for Nightly.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #8)
> This one is fixed (on 56). See bug 1388348 for Nightly.

Ugh, this landed in central after merge day. It needs to be uplifted to beta, since it only affects 56.

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field

Approval Request Comment

[Feature/Bug causing the regression]: - 

[User impact if declined]: search field in Preferences is cut in some localized builds (e.g. French)

[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: it was verified on Nightly before the visual refresh.

[Needs manual test from QE? If yes, steps to reproduce]: -

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: only setting a larger width on the search field.

[String changes made/needed]: none

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892303 [details]
Bug 1385902 - Extend the width of preferences search field

Search field width fix for l10n. OK for beta 2.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cafff29b45a

Comment 13

[Hani Yacoub, Desktop QA]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1388348#c35, I'll mark this as Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and a new bug is logged for Ubuntu bug 1392601.