1386765 - BOUNCERLATESTCHECKS CRITICAL - FAIL - 11 products checked

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

We're getting lots of these today I suppose as a follow-up of me updating mergeduty bouncer entries for nightlies, as part of mergeduty[1].

mtabara> weird thing is, I actually double checked all the files for all the platforms before I made the change
18:34:39 <mtabara> hm, I'd better file a bug instead. easier to track and also to add some heads-up in the mergeduty docs for future if we ever change stuff in bouncer.
18:35:10 <aki> duplicate products for localized firefox-nightly-stub - expected 2 found 1 different values https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-central-l10n/Firefox, https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-central-l10n/Firefox
18:35:37 <aki> is there a space in front of one?
18:35:49 <aki> oh, expected 2
18:36:37 <mtabara> before it was "firefox-56.0a1.:lang.win32.installer-stub.exe" and now is "Firefox Installer.:lang.exe"

More of this in #platform-ops-alerts


[1]: https://github.com/mozilla/releasewarrior/blob/master/how-tos/mergeduty.md#bump-bouncer-versions

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

:nthomas - I have updated [1][2] entries with "Firefox Installer.:lang.exe" instead of "firefox-56.0a1.:lang.win32.installer-stub.exe for both win32/64.

We're still supporting both in beetmoverscript and push them both so I can easily change back to what it was before. I just thought it's nice to make that chance in bouncer as well as follow-up of bug 1372260. 

What do you think?

[1]: https://bounceradmin.mozilla.com/admin/mirror/location/?product__id__exact=6509
[2]: https://bounceradmin.mozilla.com/admin/mirror/location/?product__id__exact=6512
[3]: https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/templates/firefox_nightly_repacks.yml#L67

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Aki pulled this error: "duplicate products for localized firefox-nightly-stub - expected 2 found 1 different values https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-central-l10n/Firefox, https://download-installer.cdn.mozilla.net/pub/firefox/nightly/latest-mozilla-central-l10n/Firefox" from nagios[1]

[1]: https://nagios1.private.releng.scl3.mozilla.com/releng-scl3/

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

I replaced the space with a %20 in bouncer to follow our form on other locations, and that resolved the problem. A "curl -IL" request worked fine with the space (resulted in a 200), but something in the nagios check was splitting on the space.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

FWIW, the code for this lives at https://hg.mozilla.org/build/nagios-tools/file/default/nagios_tools/scripts/check_bouncer.py.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Thanks for taking care of this :nthomas!