Closed
Bug 1387492
Opened 8 years ago
Closed 8 years ago
Allow remote Mobile Bookmarks children to be deleted
Categories
(Firefox for iOS :: Sync, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: eoger, Assigned: rnewman)
References
Details
(Whiteboard: [Sync Q3 OKR])
Allow only direct bookmarks children of the Mobile Bookmarks folder to be deleted.
This should also be behind the AppConstants.simpleBookmarksSyncing.
|
Assignee | |
Comment 1•8 years ago
|
||
N.B., local mobile bookmarks can always be deleted. That code flow shouldn't change.
|
Reporter | |
Updated•8 years ago
|
Summary: Allow Mobile Bookmarks children to be deleted → Allow remote Mobile Bookmarks children to be deleted
|
|
||
Updated•8 years ago
|
Whiteboard: [Sync Q3 OKR]
|
|
Assignee | |
Comment 2•8 years ago
|
||
In current master the only thing that needs to be done in this bug is that direct children of the buffer Mobile Bookmarks folder are not deletable. We correctly exclude folders and include all local bookmarks.
|
|
Assignee | |
Comment 3•8 years ago
|
||
|
|
Assignee | |
Comment 4•8 years ago
|
||
Part 1 (DB change): https://github.com/mozilla-mobile/firefox-ios/commit/7c9bbc58fe1e786aeab297c65ed3aed9fe0fc7dd
Part 2 (logic): https://github.com/mozilla-mobile/firefox-ios/commit/6355ec3b79b51874e7227b9c2ae71e07f858c80e
Assignee: nobody → rnewman
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
Bug 1389626 tracks turning this on in Beta and local builds.
You need to log in
before you can comment on or make changes to this bug.
Description
•