Please report any other irregularities here.
|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
--toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted are largely unused; only the dark theme uses --toolbarbutton-icon-fill-inverted as intended to change icon colors. The variables are footguns in that people think they should somehow use them when they really shouldn't, see bug 1384898, bug 1384893, bug 1384895, and pocket.css.
It would be nice if we could simply use currentColor + some (fill-)opacity rules, and avoid setting any colors. This way, it's possible to get rid of the clumsy brighttext attributes/pseudo selectors and simply rely on the text color.
Comment on attachment 8894086 [details] Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. https://reviewboard.mozilla.org/r/165182/#review170684
Attachment #8894086 - Flags: review?(jhofmann) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2526325fcf8e Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. r=johannh
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.