bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Theme
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
--toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted are largely unused; only the dark theme uses --toolbarbutton-icon-fill-inverted as intended to change icon colors. The variables are footguns in that people think they should somehow use them when they really shouldn't, see bug 1384898, bug 1384893, bug 1384895, and pocket.css.
Comment hidden (mozreview-request)

Comment 2

11 months ago
It would be nice if we could simply use currentColor + some (fill-)opacity rules, and avoid setting any colors.

This way, it's possible to get rid of the clumsy brighttext attributes/pseudo selectors and simply rely on the text color.

Comment 3

11 months ago
mozreview-review
Comment on attachment 8894086 [details]
Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted.

https://reviewboard.mozilla.org/r/165182/#review170684
Attachment #8894086 - Flags: review?(jhofmann) → review+

Comment 4

11 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2526325fcf8e
Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. r=johannh

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2526325fcf8e
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.