1388312 - 56.0b1 update tests fail: MAR_CHANNEL_MISMATCH_ERROR

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Johan Lorenzo [:jlorenzo]]

56.0b1 build 3 had its update tests fail. :nthomas found:

> 12:09:19 
<•nthomas> the mac failures on error 22 are a MAR_CHANNEL_MISMATCH_ERROR (https://dxr.mozilla.org/mozilla-beta/source/toolkit/mozapps/update/common/errors.h)
> 12:09:38 
<•nthomas> http://archive.mozilla.org/pub/devedition/candidates/56.0b1-candidates/build3/update/mac/kn/firefox-56.0b1.complete.mar is tagged firefox-mozilla-central

It turns out, we haven't cleaned up that special case[2]

[1] https://tools.taskcluster.net/groups/BoyrEYDOTWCZSOZ8u23YiA/tasks/DKO6I7UgTSiFyxl3BNLW2A/details
[2] https://dxr.mozilla.org/build-central/rev/eabdc4bddbfd9812c836fd6ddf9fb788ada8916e/tools/lib/python/kickoff/__init__.py#168

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1388312 - 56.0b1 update tests fail: MAR_CHANNEL_MISMATCH_ERROR

Review commit: https://reviewboard.mozilla.org/r/166000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166000/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Landed on default at https://hg.mozilla.org/build/tools/rev/abe1efa0f593718b497b3aa5adefb0e031ec1964

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1388312 - fix the mar tools location in beta.

Review commit: https://reviewboard.mozilla.org/r/166144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166144/

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8895012 [details]
Bug 1388312 - fix the mar tools location in beta.

https://reviewboard.mozilla.org/r/166144/#review171340

::: lib/python/kickoff/__init__.py:180
(Diff revision 1)
> +                elif branch == "mozilla-release":
> +                    # if we don't get releasetasks in-tree by the time 56 get
> +                    # to release, we need to add here the last working release,
> +                    # either that's 55.0 or 55.0.X mar/mbsdiff build on BB mac
> +                    # native hardware - see bug 1388460 for more details
> +                    pass

I'd raise an exception here, since if we get this far without ripping this code out, we are then going to fail 56.x release :-) -- And an exception will help releaseduty easily notice whats wrong.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8895012 [details]
Bug 1388312 - fix the mar tools location in beta.

https://hg.mozilla.org/build/tools/rev/9657b6ff2fbe
Landed on default and pulled to bm85.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Pushing a follow-up fix - https://hg.mozilla.org/build/tools/rev/12b3191c23e9

Comment 7

[Intermittent Failures Robot]

154 failures in 182 pushes (0.846 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-beta: 154

Platform breakdown:
* osx-10-10: 106
* windows8-64: 24
* windows8-32: 24

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1388312&startday=2017-08-08&endday=2017-08-08&tree=all

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Patches from this bug solved the problem, last 56.0b1-build5 went out smoothly.
I think we can close this.

Comment 9

[Intermittent Failures Robot]

153 failures in 901 pushes (0.17 failures/push) were associated with this bug in the last 7 days. 

This is the #4 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-beta: 153

Platform breakdown:
* osx-10-10: 106
* windows8-64: 24
* windows8-32: 23

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1388312&startday=2017-08-07&endday=2017-08-13&tree=all