Closed Bug 1388312 Opened 3 years ago Closed 3 years ago
.0b1 update tests fail: MAR _CHANNEL _MISMATCH _ERROR
56.0b1 build 3 had its update tests fail. :nthomas found: > 12:09:19 <•nthomas> the mac failures on error 22 are a MAR_CHANNEL_MISMATCH_ERROR (https://dxr.mozilla.org/mozilla-beta/source/toolkit/mozapps/update/common/errors.h) > 12:09:38 <•nthomas> http://archive.mozilla.org/pub/devedition/candidates/56.0b1-candidates/build3/update/mac/kn/firefox-56.0b1.complete.mar is tagged firefox-mozilla-central It turns out, we haven't cleaned up that special case  https://tools.taskcluster.net/groups/BoyrEYDOTWCZSOZ8u23YiA/tasks/DKO6I7UgTSiFyxl3BNLW2A/details  https://dxr.mozilla.org/build-central/rev/eabdc4bddbfd9812c836fd6ddf9fb788ada8916e/tools/lib/python/kickoff/__init__.py#168
Attachment #8894841 - Flags: review?(mtabara) → review+
Landed on default at https://hg.mozilla.org/build/tools/rev/abe1efa0f593718b497b3aa5adefb0e031ec1964
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8895012 [details] Bug 1388312 - fix the mar tools location in beta. https://reviewboard.mozilla.org/r/166144/#review171340 ::: lib/python/kickoff/__init__.py:180 (Diff revision 1) > + elif branch == "mozilla-release": > + # if we don't get releasetasks in-tree by the time 56 get > + # to release, we need to add here the last working release, > + # either that's 55.0 or 55.0.X mar/mbsdiff build on BB mac > + # native hardware - see bug 1388460 for more details > + pass I'd raise an exception here, since if we get this far without ripping this code out, we are then going to fail 56.x release :-) -- And an exception will help releaseduty easily notice whats wrong.
Attachment #8895012 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8895012 [details] Bug 1388312 - fix the mar tools location in beta. https://hg.mozilla.org/build/tools/rev/9657b6ff2fbe Landed on default and pulled to bm85.
Attachment #8895012 - Flags: checked-in+
Pushing a follow-up fix - https://hg.mozilla.org/build/tools/rev/12b3191c23e9
Patches from this bug solved the problem, last 56.0b1-build5 went out smoothly. I think we can close this.
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.