Closed Bug 1388561 Opened 7 years ago Closed 7 years ago

Remove SMILE usage in SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

Product:
SeaMonkey
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.54 fixed, seamonkey2.55 fixed, seamonkey2.53 unaffected)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.55
Tracking Flags:
Tracking Status
seamonkey2.54 --- fixed
seamonkey2.55 --- fixed
seamonkey2.53 --- unaffected

People

(Reporter: frg, Assigned: frg)

References

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(3 files)

1388561-SMILEnoMore.patch
80.13 KB, patch
Details | Diff | Splinter Review
Alternate patch part1 remove SMILE usage in SeaMonkey
9.05 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review
Alternate patch part2 move extIApplication to SeaMonkey SMILE
33.18 KB, patch
frg
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1278067 +++

Bug 1090880 has removed FUEL module from Firefox. The SeaMonkey equivalent is SMILE.

Bug 1354205 will remove the last traces of FUEL from the mozilla source tree. We are still using toolkit/components/exthelper/extApplication.js in SMILE. 

I am convinced that given the latest round of removals older add-ons will no longer function anyway with or without SMILE so I think it could be removed.

The alternative is to move exthelper to suite.

        Attachment #8895141 -
        Flags: review?(iann_bugzilla)

    
    

    
  
Need to check if any add-ons require this functionality, so probably safer to take the alternate route for the short term.

    
    

    
  
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/adfba6a54bbe
Move Toolkit extIApplication from Toolkit to Seamonkey SMILE. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8895324 [details] [diff] [review]
Alternate patch part2 move extIApplication to SeaMonkey SMILE

rs=bustage-fix

        Attachment #8895324 -
        Flags: review+

    
  

        Attachment #8895141 -
        Flags: review?(iann_bugzilla)

    
  

        Attachment #8895323 -
        Flags: review?(iann_bugzilla)

    
    

    
  
I landed part 2 of the alternate patch with rs to unbreak the tree. exthelper.xpt re-added too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: remove SMILE module from SeaMonkey → Remove SMILE usage in SeaMonkey

    
  
Status: REOPENED → ASSIGNED

    
    

    
  
Comment on attachment 8895323 [details] [diff] [review]
Alternate patch part1 remove SMILE usage in SeaMonkey

LGTM r=me

        Attachment #8895323 -
        Flags: review?(iann_bugzilla) → review+

    
    

    
  
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5ee768e3a01b
Remove SMILE usage in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED

    
  

          status-seamonkey2.55:
          --- → fixed
Target Milestone: --- → seamonkey2.55

    
    

    
  
part 1 is optional. Not asking for beta approval.

          status-seamonkey2.54:
          affected → fixed

    
  
Blocks: 1435621

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: